Skip to content

[Fix] HomeView background Color 수정#3

Merged
ParkSeongGeun merged 1 commit intodevfrom
fix/backgroundColor
Sep 30, 2025
Merged

[Fix] HomeView background Color 수정#3
ParkSeongGeun merged 1 commit intodevfrom
fix/backgroundColor

Conversation

@ParkSeongGeun
Copy link
Copy Markdown
Contributor

@ParkSeongGeun ParkSeongGeun commented Sep 30, 2025

개요

HomeView background Color 수정입니다.

Summary by CodeRabbit

  • New Features
    • Added location-based nearest bus stop lookup with route details and loading state feedback.
  • Style
    • Updated Home screen background to use the primary brand color.
  • Tests
    • Introduced comprehensive unit tests for location and bus stop management, including performance checks.
    • Added a dedicated test target to the project.
  • Chores
    • Updated ignore rules to exclude common macOS/Xcode, Swift Package Manager, and CocoaPods artifacts.

@ParkSeongGeun ParkSeongGeun self-assigned this Sep 30, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a test target and unit tests, introduces BusStopManager, LocationManager, and related models, updates HomeView colors, creates a placeholder APIManager, and extends .gitignore. Project configuration is updated to include the new test target and build settings. No existing public APIs changed aside from new types.

Changes

Cohort / File(s) Summary
Ignore rules
ComfortableMove/.gitignore
Adds ignores for macOS, Xcode, SPM, and CocoaPods artifacts (e.g., .DS_Store, xcuserdata, DerivedData, .swiftpm/, .build/, Pods/, *.podspec).
Project configuration (test target)
ComfortableMove/ComfortableMove.xcodeproj/project.pbxproj
Adds ComfortableMoveTest target with Sources/Resources/Frameworks phases, product reference, target dependency on main app, and Debug/Release configs. Updates groups and targets list.
UI tweak
ComfortableMove/ComfortableMove/Core/Home/HomeView.swift
Replaces two background color references from Color("SecondaryPalette2") to Color("PrimaryColor"); removes a comment.
Managers (new)
.../Core/Manager/BusStopManager.swift, .../Core/Manager/LocationManager.swift, .../Core/Manager/APIManager.swift
Adds BusStopManager (CSV loading, grouping, nearest-stop lookup with async update and published state), LocationManager (CoreLocation wrapper with permission handling and one-shot callback), and a placeholder APIManager file.
Models (new)
.../Core/Model/BusStop.swift, .../Core/Model/StopWithRoutes.swift
Adds BusStop (Identifiable, Codable, coordinates and distance helper) and StopWithRoutes (Identifiable, Equatable; stop+routes aggregation).
Tests (new)
ComfortableMove/ComfortableMoveTest/BusStopManagerTests.swift, ComfortableMove/ComfortableMoveTest/LocationManagerTests.swift
Adds unit tests covering BusStopManager nearest-stop logic and loading state, and LocationManager authorization/update behavior and callback semantics.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as HomeView
  participant LM as LocationManager
  participant BSM as BusStopManager

  User->>UI: Open screen / trigger location fetch
  UI->>LM: startUpdating / refreshLocation()
  LM-->>LM: Request permission if needed
  LM-->>UI: onLocationUpdate(location) [first fix]
  UI->>BSM: findNearestStop(userLocation)
  BSM-->>UI: isLoading = true
  BSM->>BSM: Compute nearest stop (background)
  BSM-->>UI: nearestStop set (main thread)
  BSM-->>UI: isLoading = false
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

I hop between stops on a sunny route,
Sniffing CSVs—so quaint, so cute.
A location ping, a nearest cheer,
Tests thump-thump: all green here.
With palettes primed and targets set,
I bound ahead—no bugs to fret! 🐇✨

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title “[Fix] HomeView background Color 수정” only references the background color change in HomeView, but the pull request also adds multiple new manager classes, data models, unit test targets, project configuration updates, and .gitignore entries, so it does not accurately summarize the breadth of the changes. Update the title to concisely reflect the primary additions and fixes in this PR—for example, “Add BusStopManager, LocationManager, models, and unit tests; update HomeView background color”—so that it clearly conveys the full scope of the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 48.39% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/backgroundColor
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/backgroundColor

Comment @coderabbitai help to get the list of available commands and usage tips.

@ParkSeongGeun ParkSeongGeun changed the base branch from main to dev September 30, 2025 06:56
@ParkSeongGeun ParkSeongGeun merged commit 52ab1ec into dev Sep 30, 2025
1 check was pending
@ParkSeongGeun ParkSeongGeun deleted the fix/backgroundColor branch September 30, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant