Skip to content

Fix float parse error for Facade Condensation Risk Heatmap/Chart #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tom-Kingstone wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix float parse error for Facade Condensation Risk Heatmap/Chart #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions LadybugTools_Adapter/AdapterActions/Execute/FacadeCondensationRiskCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ private List<object> RunCommand(FacadeCondensationRiskCommand command, ActionCon
{
thresholds = command.Thresholds;
}
string thresholdsStr = string.Join(" ", thresholds);

string epwFile = System.IO.Path.GetFullPath(command.EPWFile.GetFullFileName());

Expand All @@ -74,9 +73,11 @@ private List<object> RunCommand(FacadeCondensationRiskCommand command, ActionCon
else
commandArg = "plot/facade_condensation_risk_chart";

// run the process
List<string> args = new List<string>() { "-command", commandArg, "-e", epwFile.Replace('\\', '/'), "-t", thresholdsStr, "-p", command.OutputLocation.Replace('\\', '/') };
//construct args: insert thresholds as a range as concatenating them into a space delimited string causes the numbers to be wrapped in quotes which breaks the python argument parser
List<string> args = new List<string>() { "-command", commandArg, "-e", epwFile.Replace('\\', '/'), "-t", "-p", command.OutputLocation.Replace('\\', '/') };
args.InsertRange(args.IndexOf("-t") + 1, thresholds.Select(x => x.ToString()));

// run the process
string result = "";
bool success;

Expand Down