Push of Free Polygonal Loads by Arne-Martensen · Pull Request #129 · BHoM/RFEM6_Toolkit

Arne-Martensen · 2025-11-03T12:21:51Z

Issues addressed by this PR

Closes #127

This PR is aming to add the feature for Pushing/Pulling Free Polygonal Loads to/from RFEM6.

Test files

Test File

For the testing please do the following:

Push Panel Structure/Nodes
Push AreaUniformlyDistributedLoad
Pull AreaUniformlyDistributedLoad
Check soundness of RFEM6 Model
Check if Pushed and Pulled Model do match.
Vary AreaUniformlyDistributedLoad preassure direction (Axis Parallel X, Y or Z) and Vary Axis (Local, Glabal) and Projected (True/False)

Changelog

Added Pull Method for AreaUniformlyDistributedLoad with added Polygon Parameter
Added Push Method for AreaUniformlyDistributedLoad with added Polygon Parameter

Implemented reading and conversion of RFEM6 free polygon loads as AreaUniformlyDistributedLoad objects. Added ReadPolygonLoad method and FromRFEM conversion for free_polygon_load, including handling of load direction, axis, and projection. Updated unit test to enable pulling panels for verification.

Added logic to extract and construct polygon geometry from RFEM6 polygon load data, handling different projection types. The resulting polygon is now attached to AreaUniformlyDistributedLoad objects. Also added a unit test for pulling uniformly distributed area loads and commented out a redundant panel push in test setup.

Introduces handling of AreaUniformlyDistributedLoad objects with Polygon custom data. Adds CreateLoad_Polygon method and ToRFEM6_Polygon extension to convert and assign polygonal area loads to RFEM6, supporting different plane orientations and load directions.

Updated the logic to assign the load_projection value according to the orientation of the polygon's fit plane, ensuring correct projection for XY, XZ, or YZ planes. This replaces the previous hardcoded value and improves accuracy for different polygon orientations.

Wrapped the CreateLoad_Polygon logic in a try-catch block to record errors when load creation fails, such as when the polygon is non-planar or not parallel to principal planes. This improves robustness and provides clearer error reporting.

Added warnings in Load.cs to notify users when the 'Projected' option is set for area loads with the Local axis, as this combination is not supported and will be ignored. Also removed commented-out code in Panel.cs and filtered out invalid line numbers in RFEMLine.cs.

Copilot

Pull Request Overview

This PR adds support for free polygon loads in the RFEM6 adapter, enabling conversion between BHoM's AreaUniformlyDistributedLoad with polygon geometry and RFEM6's free_polygon_load type.

Implements bidirectional conversion methods for free polygon loads
Adds logic to detect polygon-based area loads via CustomData
Updates read/create methods to handle polygon loads separately from standard surface loads

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 24 comments.

Show a summary per file

File	Description
RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs	Adds `ToRFEM6_Polygon` method to convert BHoM area loads with polygon geometry to RFEM6 free polygon loads
RFEM6_Adapter/Convert/FromRFEM6/BHoMDataStructure/Loading/Load.cs	Adds `FromRFEM` method to convert RFEM6 free polygon loads back to BHoM area loads with polygon data
RFEM6_Adapter/Convert/FromRFEM6/BHoMDataStructure/Geometry/Panel.cs	Removes commented-out code
RFEM6_Adapter/CRUD/Read/IntermediateDatastructure/RFEMLine.cs	Filters line numbers to exclude non-positive IDs
RFEM6_Adapter/CRUD/Read/BHoMDataStructure/Loading/Load.cs	Extends `ReadAreaLoad` to include free polygon loads and adds new `ReadPolygonLoad` method
RFEM6_Adapter/CRUD/Create/BHoMDataStructure/Loading/Load.cs	Routes polygon-based area loads to the polygon-specific create method
.ci/unit-tests/RFEM_Toolkit_Test/BHoMDataStructure/Loading/UniformlyDistributedAreaLoad.cs	Comments out panel push in setup and adds new incomplete test for pulling loads
.ci/unit-tests/RFEM_Toolkit_Test/BHoMDataStructure/Geometry/Panel/Panel.cs	Comments out panel push and uncomments panel pull code

Comments suppressed due to low confidence (3)

RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs:1

Coordinate mapping inconsistency: For the default case (LOAD_PROJECTION_XZ_OR_UW), in ToRFEM6_Polygon the coordinates are mapped as [v.X, v.Z] (lines 282), but in FromRFEM the reverse mapping assigns X = secondCoordinate[i], Y = thirdCoordinate[i], Z = x where x is firstCoordinate. This should be X = x, Y = thirdCoordinate[i], Z = secondCoordinate[i] to be consistent with the forward conversion.

/*

RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs:292

This assignment to r is useless, since its value is never read.

            free_polygon_load_load_location_row r = new free_polygon_load_load_location_row() { row = k };

RFEM6_Adapter/CRUD/Create/BHoMDataStructure/Loading/Load.cs:255

Generic catch clause.

            } catch {
                BH.Engine.Base.Compute.RecordError($"The creation of {bhLoad} failed.\nA potential cause is that the applied polygon is non-planar or not parallel to the XY, YZ, or ZX plane.");
            }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

RFEM6_Adapter/CRUD/Read/BHoMDataStructure/Loading/Load.cs

RFEM6_Adapter/Convert/FromRFEM6/BHoMDataStructure/Loading/Load.cs

RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

Adds a warning if the AreaUniformlyDistributedLoad pressure vector is not parallel to any global axis, prompting users to verify the load direction.

DomiAcas

Tested the feature using the provided Grasshopper (.gh) script and created polygonal loads with varying directions and axes, including both projected and non-projected load types in RFEM6. Pulled loads back to .gh environment from the RFEM6 softare and checked if Pushed and Pulled Model match. The check deemed the feature successful.

Arne-Martensen · 2025-11-05T09:27:12Z

@BHoMBot check ready-to-merge

bhombot-ci · 2025-11-05T09:27:14Z

@Arne-Martensen to confirm, the following actions are now queued:

check ready-to-merge

There are 4 requests in the queue ahead of you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Corrected the typo from 'polgon' to 'polygon' in multiple places and added assignment of 'loadProjection' based on the polygon's fit plane orientation.

Arne-Martensen · 2025-11-05T10:51:08Z

@BHoMBot check compliance

Arne-Martensen · 2025-11-05T10:51:14Z

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

Arne-Martensen · 2025-11-05T12:32:40Z

@BHoMBot check compliance

Corrected spelling errors in log messages and standardized the variable name from 'loadMagintude' to 'loadMagnitude' in the Load.cs files for improved code clarity and consistency.

Deleted the ReadPolygonLoad method from Load.cs as it is no longer needed. This helps clean up the codebase and removes dead code.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…thub.com/BHoM/RFEM6_Toolkit into RFEM6_Toolkit-#127-AddFreePolygonalLoads

Arne-Martensen · 2025-11-05T14:47:12Z

@BHoMBot check compliance

Arne-Martensen · 2025-11-05T15:40:31Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-11-05T15:40:44Z

@Arne-Martensen I've opened a new pull request, #132, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

DomiAcas

Tested the feature again using the provided Grasshopper (.gh) script and created polygonal loads with varying directions and axes, including both projected and non-projected load types in RFEM6. Pulled loads back to .gh environment from the RFEM6 softare and checked if Pushed and Pulled Model match. The check deemed the feature successful.

Arne-Martensen added 6 commits October 27, 2025 18:10

Arne-Martensen requested review from DomiAcas and Copilot November 3, 2025 12:21

Arne-Martensen self-assigned this Nov 3, 2025

Arne-Martensen added size:L Measured in days type:feature New capability or enhancement labels Nov 3, 2025

Copilot AI reviewed Nov 3, 2025

View reviewed changes

Warn if load direction is not axis-aligned

14343b2

Adds a warning if the AreaUniformlyDistributedLoad pressure vector is not parallel to any global axis, prompting users to verify the load direction.

Arne-Martensen marked this pull request as ready for review November 4, 2025 08:12

DomiAcas previously approved these changes Nov 5, 2025

View reviewed changes

Arne-Martensen dismissed DomiAcas’s stale review via 6256d15 November 5, 2025 09:46

Arne-Martensen and others added 8 commits November 5, 2025 10:46

Update RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

6256d15

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

56d3f53

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

6557de1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/Convert/ToRFEM6/BHoMDataStructure/Loading/Load.cs

13118ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/CRUD/Read/BHoMDataStructure/Loading/Load.cs

9d09184

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/CRUD/Read/BHoMDataStructure/Loading/Load.cs

fba38de

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RFEM6_Adapter/Convert/FromRFEM6/BHoMDataStructure/Loading/Load.cs

7f69ab5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix variable name typo and add loadProjection assignment

51100f6

Corrected the typo from 'polgon' to 'polygon' in multiple places and added assignment of 'loadProjection' based on the polygon's fit plane orientation.

Fix typos and variable naming in Load.cs files

8c5befa

Corrected spelling errors in log messages and standardized the variable name from 'loadMagintude' to 'loadMagnitude' in the Load.cs files for improved code clarity and consistency.

Arne-Martensen and others added 5 commits November 5, 2025 15:36

Remove unused ReadPolygonLoad method

2dec64a

Deleted the ReadPolygonLoad method from Load.cs as it is no longer needed. This helps clean up the codebase and removes dead code.

Update RFEM6_Adapter/CRUD/Create/BHoMDataStructure/Loading/Load.cs

b5d3cbe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Load.cs

621a5bd

Merge branch 'RFEM6_Toolkit-#127-AddFreePolygonalLoads' of https://gi…

b6971d0

…thub.com/BHoM/RFEM6_Toolkit into RFEM6_Toolkit-#127-AddFreePolygonalLoads

Update Load.cs

0d37827

Copilot AI mentioned this pull request Nov 5, 2025

[WIP] Add feature to push free polygonal loads to RFEM6 #132

Closed

Arne-Martensen requested review from DomiAcas and Copilot November 5, 2025 15:43

Copilot AI reviewed Nov 5, 2025

View reviewed changes

DomiAcas approved these changes Nov 7, 2025

View reviewed changes

peterjamesnugent merged commit 949f6f7 into develop Nov 10, 2025
15 of 16 checks passed

peterjamesnugent deleted the RFEM6_Toolkit-#127-AddFreePolygonalLoads branch November 10, 2025 09:10

Arne-Martensen restored the RFEM6_Toolkit-#127-AddFreePolygonalLoads branch November 25, 2025 09:01

BHoMBot mentioned this pull request Dec 15, 2025

9.0 Deployment #133

Merged

Arne-Martensen deleted the RFEM6_Toolkit-#127-AddFreePolygonalLoads branch February 17, 2026 16:22

Conversation

Arne-Martensen commented Nov 3, 2025

Issues addressed by this PR

Test files

Changelog

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DomiAcas left a comment

Choose a reason for hiding this comment

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

bhombot-ci bot commented Nov 5, 2025

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

Arne-Martensen commented Nov 5, 2025

Uh oh!

Copilot AI commented Nov 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

DomiAcas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants