Skip to content

Fix some typos (mostly in comments, found by codespell) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stweil wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix some typos (mostly in comments, found by codespell) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion module/Bsz/src/Bsz/Config/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public function isIsilSession()
}

/**
* Does this entity alreay have an isil stored in session (ill portal)
* Does this entity already have an isil stored in session (ill portal)
* @return bool
*/
public function hasIsilSession()
Expand Down
8 changes: 4 additions & 4 deletions module/Bsz/src/Bsz/Controller/RecordController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public function freeFormAction()
}

/**
* Determin if we should use the test or live url.
* Determine if we should use the test or live url.
* @return boolean
*/
private function isTestMode()
Expand All @@ -256,7 +256,7 @@ private function isDev()
}

/**
* Determin if we should use the test or live url.
* Determine if we should use the test or live url.
* @return boolean
*/
public function getCustomUrl()
Expand Down Expand Up @@ -357,11 +357,11 @@ public function parseResponse($html)
// so if it matches is returns 1 which is casted to true
if ((bool)preg_match('/Bestell-Id:\s*(\d*)/', $html->textContent, $id) === true) {
$this->orderId = $id[1];
// Order is successfull
// Order is successful
$this->flashMessenger()->addSuccessMessage('ILL::request_submit_ok');
return true;
} else {
// order not successfull - disable error reporting because
// order not successful - disable error reporting because
// preg_match errors may occur.
$error_reporting = error_reporting();
error_reporting(0);
Expand Down
6 changes: 3 additions & 3 deletions module/Bsz/src/Bsz/Controller/Search2RecordController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public function freeFormAction()
}

/**
* Determin if we should use the test or live url.
* Determine if we should use the test or live url.
* @return boolean
*/
private function isTestMode()
Expand Down Expand Up @@ -379,11 +379,11 @@ public function parseResponse($html)
// so if it matches is returns 1 which is casted to true
if ((bool)preg_match('/Bestell-Id:\s*(\d*)/', $html->textContent, $id) === true) {
$this->orderId = $id[1];
// Order is successfull
// Order is successful
$this->flashMessenger()->addSuccessMessage('ILL::request_submit_ok');
return true;
} else {
// order not successfull - disable error reporting because
// order not successful - disable error reporting because
// preg_match errors may occur.
$error_reporting = error_reporting();
error_reporting(0);
Expand Down
2 changes: 1 addition & 1 deletion module/Bsz/src/Bsz/Debug.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public static function isInternal()
}

/**
* Determin if running on Test Server
* Determine if running on Test Server
* @return boolean
*/
public static function isDev()
Expand Down
8 changes: 4 additions & 4 deletions module/Bsz/src/Bsz/ILL/Logic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ protected function determineStatus()

/**
* Returns the unique status code
* TODO: this method shoudl return something from conffiguration. *
* TODO: this method should return something from configuration. *
* @return int
*/
public function getStatusCode()
Expand All @@ -221,7 +221,7 @@ public function getMessages()
{
/*
* TODO there are still some messages set in methods. These should be
* removed to the configuration. It might be neccessary to split those
* removed to the configuration. It might be necessary to split those
* methods into exactly one task.
*/
$retval = $this->messages;
Expand Down Expand Up @@ -313,7 +313,7 @@ protected function checkSerialOrCollection(): bool
}

/**
* Determin if an item is available locally. Checks for
* Determine if an item is available locally. Checks for
* * 924 entries
* * Parallel editions in SWB
* * Similar results from SWB (if network != SWB) *
Expand Down Expand Up @@ -492,7 +492,7 @@ protected function hasParallelEditions()

/**
* Check if it is a journal and available locally. Journals can always be
* ordnered because we can't evauluate their exact holding dates.
* ordnered because we can't evaluate their exact holding dates.
* @return bool
*/
protected function checkJournalAvailable(): bool
Expand Down
10 changes: 5 additions & 5 deletions module/Bsz/src/Bsz/RecordDriver/SolrGviMarc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public function getURLs(): array
$ind2 = $field['i2'];

// we don't want to show licensed content
// ind1,2 = 4,0 is probably lincensed content.
// ind1,2 = 4,0 is probably licensed content.
// only if we find a kostenfrei in |z, we use the link
// special case: DE-950 Proquest links are shown
if (!$is950 && $ind1 == 4 && $ind2 == 0) {
Expand Down Expand Up @@ -860,10 +860,10 @@ public function getVolumeNumber()
}

/**
* get local Urls from 924|k and the correspondig linklabel 924|l
* get local Urls from 924|k and the corresponding linklabel 924|l
* - $924 is repeatable
* - |k is repeatable, |l aswell
* - we can have more than one isil ?is this true? maybe allways the first isil
* - |k is repeatable, |l as well
* - we can have more than one isil ?is this true? maybe always the first isil
* - different Urls from one instition may have different issues (is this true?)
* @return array
*/
Expand All @@ -883,7 +883,7 @@ public function getLocalUrls()
}

/**
* Anonymous function, called bellow. It handles ONE url.
* Anonymous function, called below. It handles ONE url.
*
* @param $link
* @param $label
Expand Down
2 changes: 1 addition & 1 deletion module/Bsz/src/Bsz/Resolver/Driver/Ill.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ protected function downgradeOpenUrl($params)
}
}

// remove date info for journals because users must choose themselfes.
// remove date info for journals because users must choose themselves.
if ($newParams['genre'] == 'journal') {
unset($newParams['date']);
}
Expand Down
2 changes: 1 addition & 1 deletion module/BszTheme/src/BszTheme/ThemeInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
namespace BszTheme;

/**
* BSZ implementation of ThemeInfo, here we load all client specific ressources.
* BSZ implementation of ThemeInfo, here we load all client specific resources.
*
* @author Cornelius Amzar <cornelius.amzar@bsz-bw.de>
*/
Expand Down
2 changes: 1 addition & 1 deletion module/BszTheme/src/BszTheme/View/Helper/Bodensee/IllForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ protected function renderBibliographicFieldsArticle()
{
// the first is the label, the second the fieldname, third the value
// arrays in value are allowed, they are imploded later
// most fields here are populated from the containg record
// most fields here are populated from the containing record
$container = $this->driver->getContainer();
$container = array_shift($container);
$author = '';
Expand Down
6 changes: 3 additions & 3 deletions module/BszTheme/src/BszTheme/View/Helper/Bodensee/Mapongo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ public function __construct(\Bsz\Config\Client $config)
/**
* Invoked in the template, returns HTML
*
* @param string $signatur
* @param string $signature
* @param string $lang
* @return string
*/
public function __invoke($signatur, $lang = 'de')
public function __invoke($signature, $lang = 'de')
{
preg_match('/\|\s(.*)/', $signatur, $matches);
preg_match('/\|\s(.*)/', $signature, $matches);
$rvk = $matches[1] ?? '';
return $this->render($rvk, $lang);
}
Expand Down
2 changes: 1 addition & 1 deletion module/BszTheme/src/BszTheme/View/Helper/Bodensee/RecordLink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function linkToOpac($opacUrl, $ppn): string
}

/**
* This method renders the author names well formated as HTML
* This method renders the author names well formatted as HTML
*
* @param SolrMarc $driver
* @param int $number 1 to number of authors
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee/js/vendor/bootstrap-datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@
options = typeof option === 'object' && option;
if (!data){
var elopts = opts_from_el(this, 'date'),
// Preliminary otions
// Preliminary options
xopts = $.extend({}, defaults, elopts, options),
locopts = opts_from_locale(xopts.language),
// Options priority: js args, data-attrs, locales, defaults
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee/templates/bsz/mzbihs/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p>
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Intergated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Integrated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
</p>
<p>
For technical questions and suggestions: <a href="javascript:window.location.href = 'mailto:' + ['boss-support','bsz-bw.de'].join('@')">boss-support@bsz-bw.de</a><br/><br/>
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee/templates/bsz/wlb/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@

<p>
<h4>Provision times</h4>
Occasionally there may be delays in the fulfilment of your orders from our external stock. Media that can be collected are listed in your account under "Reservation". If you have entered an e-mail address, you will be informed by selecting "Notification for provided items".
Occasionally there may be delays in the fulfillment of your orders from our external stock. Media that can be collected are listed in your account under "Reservation". If you have entered an e-mail address, you will be informed by selecting "Notification for provided items".
</p>
2 changes: 1 addition & 1 deletion themes/bodensee/theme.config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
],
'aliases' => [
/**
* Icons can be assigned or overriden here
* Icons can be assigned or overridden here
*
* Format: 'icon' => [set:]icon[:extra_classes]
* Icons assigned without set will use the defaultSet.
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee5/js/vendor/bootstrap-datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@
options = typeof option === 'object' && option;
if (!data){
var elopts = opts_from_el(this, 'date'),
// Preliminary otions
// Preliminary options
xopts = $.extend({}, defaults, elopts, options),
locopts = opts_from_locale(xopts.language),
// Options priority: js args, data-attrs, locales, defaults
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee5/templates/bsz/mzbihs/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p>
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Intergated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Integrated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
</p>
<p>
For technical questions and suggestions: <a href="javascript:window.location.href = 'mailto:' + ['boss-support','bsz-bw.de'].join('@')">boss-support@bsz-bw.de</a><br/><br/>
Expand Down
2 changes: 1 addition & 1 deletion themes/bodensee5/templates/bsz/wlb/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@

<p>
<h4>Provision times</h4>
Occasionally there may be delays in the fulfilment of your orders from our external stock. Media that can be collected are listed in your account under "Reservation". If you have entered an e-mail address, you will be informed by selecting "Notification for provided items".
Occasionally there may be delays in the fulfillment of your orders from our external stock. Media that can be collected are listed in your account under "Reservation". If you have entered an e-mail address, you will be informed by selecting "Notification for provided items".
</p>
2 changes: 1 addition & 1 deletion themes/bodensee5/theme.config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
],
'aliases' => [
/**
* Icons can be assigned or overriden here
* Icons can be assigned or overridden here
*
* Format: 'icon' => [set:]icon[:extra_classes]
* Icons assigned without set will use the defaultSet.
Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap3/js/vendor/leaflet/leaflet.markercluster-src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ L.MarkerClusterGroup.include({
//Force a browser layout of stuff in the map
// Should apply the current opacity and location to all elements so we can update them again for an animation
_forceLayout: function () {
//In my testing this works, infact offsetWidth of any element seems to work.
//In my testing this works, in fact offsetWidth of any element seems to work.
//Could loop all this._layers and do this for each _icon if it stops working

L.Util.falseFn(document.body.offsetWidth);
Expand Down Expand Up @@ -2518,7 +2518,7 @@ L.MarkerClusterGroup.include({
this._map.getRenderer(this);
//Needs to happen in the pageload, not after, or animations don't work in webkit
// http://stackoverflow.com/questions/8455200/svg-animate-with-dynamically-added-elements
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticable
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticeable
}
},

Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap3/js/vendor/leaflet/leaflet.markercluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ L.MarkerClusterGroup.include({
//Force a browser layout of stuff in the map
// Should apply the current opacity and location to all elements so we can update them again for an animation
_forceLayout: function () {
//In my testing this works, infact offsetWidth of any element seems to work.
//In my testing this works, in fact offsetWidth of any element seems to work.
//Could loop all this._layers and do this for each _icon if it stops working

L.Util.falseFn(document.body.offsetWidth);
Expand Down Expand Up @@ -2518,7 +2518,7 @@ L.MarkerClusterGroup.include({
this._map.getRenderer(this);
//Needs to happen in the pageload, not after, or animations don't work in webkit
// http://stackoverflow.com/questions/8455200/svg-animate-with-dynamically-added-elements
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticable
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticeable
}
},

Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap5/js/lightbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ VuFind.register('lightbox', function Lightbox() {
var _modalParams = {};
// Elements
var _modal, _modalBody, _clickedButton = null;
// Boostrap modal
// Bootstrap modal
var _bsModal = null;
// Utilities
function _storeClickedStatus() {
Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap5/js/vendor/leaflet/leaflet.markercluster-src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ L.MarkerClusterGroup.include({
//Force a browser layout of stuff in the map
// Should apply the current opacity and location to all elements so we can update them again for an animation
_forceLayout: function () {
//In my testing this works, infact offsetWidth of any element seems to work.
//In my testing this works, in fact offsetWidth of any element seems to work.
//Could loop all this._layers and do this for each _icon if it stops working

L.Util.falseFn(document.body.offsetWidth);
Expand Down Expand Up @@ -2518,7 +2518,7 @@ L.MarkerClusterGroup.include({
this._map.getRenderer(this);
//Needs to happen in the pageload, not after, or animations don't work in webkit
// http://stackoverflow.com/questions/8455200/svg-animate-with-dynamically-added-elements
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticable
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticeable
}
},

Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap5/js/vendor/leaflet/leaflet.markercluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ L.MarkerClusterGroup.include({
//Force a browser layout of stuff in the map
// Should apply the current opacity and location to all elements so we can update them again for an animation
_forceLayout: function () {
//In my testing this works, infact offsetWidth of any element seems to work.
//In my testing this works, in fact offsetWidth of any element seems to work.
//Could loop all this._layers and do this for each _icon if it stops working

L.Util.falseFn(document.body.offsetWidth);
Expand Down Expand Up @@ -2518,7 +2518,7 @@ L.MarkerClusterGroup.include({
this._map.getRenderer(this);
//Needs to happen in the pageload, not after, or animations don't work in webkit
// http://stackoverflow.com/questions/8455200/svg-animate-with-dynamically-added-elements
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticable
//Disable on touch browsers as the animation messes up on a touch zoom and isn't very noticeable
}
},

Expand Down
2 changes: 1 addition & 1 deletion themes/bsz/templates/bsz/mzbihs/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p>
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Intergated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Integrated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
</p>
<p>
For technical questions and suggestions: <a href="javascript:window.location.href = 'mailto:' + ['boss-support','bsz-bw.de'].join('@')">boss-support@bsz-bw.de</a><br/><br/>
Expand Down
2 changes: 1 addition & 1 deletion themes/bsz/templates/bsz/mzub/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p>
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Intergated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Integrated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
</p>
<p>
For technical questions and suggestions: <a href="javascript:window.location.href = 'mailto:' + ['boss-support','bsz-bw.de'].join('@')">boss-support@bsz-bw.de</a><br/><br/>
Expand Down
2 changes: 1 addition & 1 deletion themes/reichenau/templates/bsz/mzbihs/en.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</p>

<p>
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Intergated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
This is a testapplication for connecting the Discovery System <a href="https://wiki.bsz-bw.de/display/BOSS">BOSS</a> to the Integrated Library System <a href="https://wiki.bsz-bw.de/display/BWFOLIO">FOLIO</a>.
</p>
<p>
For technical questions and suggestions: <a href="javascript:window.location.href = 'mailto:' + ['boss-support','bsz-bw.de'].join('@')">boss-support@bsz-bw.de</a><br/><br/>
Expand Down