Skip to content

Update TpllCommand.java: Fix the offset being applied twice #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tf2mandeokyi wants to merge 1 commit into from
Closed

Update TpllCommand.java: Fix the offset being applied twice #20

tf2mandeokyi wants to merge 1 commit into from

Conversation

@tf2mandeokyi
Copy link

@tf2mandeokyi tf2mandeokyi commented Jan 10, 2024

Why apply offset again when it is already applied

Also this causes a chunk system error when the offset is not (0, 0, 0)

[16:58:48] [Tuinity Chunk System Worker #2/ERROR]: [ChunkTaskScheduler] Chunk system error at chunk (~~~,~~~), holder: NewChunkHolder{world=~~~, chunkX=~~~, chunkZ=~~~, entityChunkFromDisk=false, lastChunkCompletion={chunk_class=net.minecraft.world.level.chunk.ProtoChunk,status=minecraft:structure_references}, currentGenStatus=minecraft:structure_references, requestedGenStatus=minecraft:full, generationTask=ChunkProgressionTask{class: io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask, for world: ~~~, chunk: (~~~,~~~), hashcode: 1779680793, priority: COMPLETING, status: minecraft:biomes, scheduled: true}, generationTaskStatus=minecraft:biomes, priority=HIGHER, priorityLocked=false, neighbourRequestedPriority=IDLE, effective_priority=HIGHER, oldTicketLevel=33, currentTicketLevel=33, totalNeighboursUsingThisChunk=4, fullNeighbourChunksLoadedBitset=0, chunkStatusRaw=0, currentChunkStatus=INACCESSIBLE, pendingChunkStatus=INACCESSIBLE, is_unload_safe=ticket_level, killed=false}, exception:
java.lang.Throwable: java.util.concurrent.CompletionException: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at io.papermc.paper.chunk.system.scheduling.ChunkTaskScheduler.unrecoverableChunkSystemFailure(ChunkTaskScheduler.java:279) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.lambda$setGenerationTask$4(NewChunkHolder.java:1700) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkProgressionTask.complete0(ChunkProgressionTask.java:95) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkProgressionTask.complete(ChunkProgressionTask.java:75) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:139) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadedTaskQueue$PrioritisedTask.executeInternal(PrioritisedThreadedTaskQueue.java:351) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadedTaskQueue.executeTask(PrioritisedThreadedTaskQueue.java:118) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedThreadPool$PrioritisedThread.pollTasks(PrioritisedThreadPool.java:274) ~[paper-1.20.4.jar:git-Paper-381]
	at ca.spottedleaf.concurrentutil.executor.standard.PrioritisedQueueExecutorThread.run(PrioritisedQueueExecutorThread.java:62) ~[paper-1.20.4.jar:git-Paper-381]
Caused by: java.util.concurrent.CompletionException: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]
	at java.util.concurrent.CompletableFuture.asyncSupplyStage(CompletableFuture.java:1782) ~[?:?]
	at java.util.concurrent.CompletableFuture.supplyAsync(CompletableFuture.java:2005) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.createBiomes(ChunkGenerator.java:114) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.lambda$static$6(ChunkStatus.java:84) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.generate(ChunkStatus.java:259) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:86) ~[paper-1.20.4.jar:git-Paper-381]
	... 4 more
Caused by: java.lang.RuntimeException: net.buildtheearth.terraminusminus.projection.OutOfProjectionBoundsException
	at de.btegermany.terraplusminus.data.TerraConnector.toGeo(TerraConnector.java:31) ~[terraplusminus-1.3.2.jar:?]
	at de.btegermany.terraplusminus.gen.CustomBiomeProvider.getBiome(CustomBiomeProvider.java:30) ~[terraplusminus-1.3.2.jar:?]
	at org.bukkit.generator.BiomeProvider.getBiome(BiomeProvider.java:61) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_20_R3.generator.CustomWorldChunkManager.getNoiseBiome(CustomWorldChunkManager.java:47) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.LevelChunkSection.fillBiomesFromNoise(LevelChunkSection.java:235) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkAccess.fillBiomesFromNoise(ChunkAccess.java:535) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.lambda$createBiomes$3(ChunkGenerator.java:115) ~[paper-1.20.4.jar:git-Paper-381]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
	at java.util.concurrent.CompletableFuture.asyncSupplyStage(CompletableFuture.java:1782) ~[?:?]
	at java.util.concurrent.CompletableFuture.supplyAsync(CompletableFuture.java:2005) ~[?:?]
	at net.minecraft.world.level.chunk.ChunkGenerator.createBiomes(ChunkGenerator.java:114) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.lambda$static$6(ChunkStatus.java:84) ~[paper-1.20.4.jar:git-Paper-381]
	at net.minecraft.world.level.chunk.ChunkStatus.generate(ChunkStatus.java:259) ~[paper-1.20.4.jar:git-Paper-381]
	at io.papermc.paper.chunk.system.scheduling.ChunkUpgradeGenericStatusTask.run(ChunkUpgradeGenericStatusTask.java:86) ~[paper-1.20.4.jar:git-Paper-381]
	... 4 more

@tf2mandeokyi
Update TpllCommand.java
8c7bca3 
Fix the command re-applying the offset
@tf2mandeokyi tf2mandeokyi changed the title Update TpllCommand.java Update TpllCommand.java: Fix the offset being applied twice Jan 14, 2024
@Zoriot
Copy link
Collaborator

Zoriot commented May 5, 2025

@tf2mandeokyi is this still valid? If yes, can you please rebase?

@Zoriot Zoriot requested a review from Copilot July 31, 2025 23:24
Copilot AI reviewed Jul 31, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a double offset application bug in the TpllCommand teleportation logic that was causing chunk system errors when terrain offsets were configured to non-zero values.

Key changes:

  • Removed duplicate terrain offset application in teleportation coordinates
  • Fixed OutOfProjectionBoundsException that occurred when offsets were applied twice

src/main/java/de/btegermany/terraplusminus/commands/TpllCommand.java
player.sendMessage(Terraplusminus.config.getString("prefix") + "§7Teleporting to " + coordinates[1] + ", " + coordinates[0] + " in another world. This may take a bit...");
//player.teleport(new Location(tpWorld, mcCoordinates[0] + xOffset, height, mcCoordinates[1] + zOffset, player.getLocation().getYaw(), player.getLocation().getPitch()));
PaperLib.teleportAsync(player, new Location(tpWorld, mcCoordinates[0] + xOffset, height, mcCoordinates[1] + zOffset, player.getLocation().getYaw(), player.getLocation().getPitch()));
//player.teleport(new Location(tpWorld, mcCoordinates[0], height, mcCoordinates[1], player.getLocation().getYaw(), player.getLocation().getPitch()));

This comment was marked as outdated.

Sign in to view

@Zoriot
Copy link
Collaborator

Zoriot commented Nov 2, 2025

Superseded by #46.

@Zoriot Zoriot closed this Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tf2mandeokyi @Zoriot