🐛 Remove players when mcServer lose connection and improve region player name lookup #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that players are removed when the Minecraft server loses connection.
- Updated the copyright header.
- Applied readonly modifiers to class properties.
- Changed the removal mechanism for players to a disconnect event and improved type annotations.
Comments suppressed due to low confidence (1)
backend/src/util/SocketIOController.ts:71
- [nitpick] Consider renaming the variable 'u' to something more descriptive, such as 'userSegment', to improve code clarity.
split.forEach((u: string) => {
Zoriot
force-pushed
the
bug/fixPlayerData
branch
from
5bdf269 to
41157d4
Compare
Should fix the issue that sometimes there are players on the map who are not online on the server. Also fixed a build issue and updated the pipeline config to work again on pr's.
Zoriot
force-pushed
the
bug/fixPlayerData
branch
from
41157d4 to
78981b9
Compare
Nudelsuppe42
approved these changes
Apr 19, 2025
Nudelsuppe42
left a comment
Nudelsuppe42
left a comment
There was a problem hiding this comment.
Wenns funktioniert.
RegionView.jsx gehört zwar nicht dazu aber gut 😄
Zoriot
changed the title
Collaborator
Author
Keine Ahnung, ob es funktioniert. Wüsste nicht, wie ich das halbwegs einfach testen kann. |
Nachwahl
approved these changes
Apr 20, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue that sometimes there are players on the map who are not online on the server.