Skip to content

[Snyk] Upgrade @octokit/core from 5.0.1 to 5.2.2#6

Open
mysommer wants to merge 1 commit intomainfrom
snyk-upgrade-0d56e16f215eda9f75e7540775ca106e
Open

[Snyk] Upgrade @octokit/core from 5.0.1 to 5.2.2#6
mysommer wants to merge 1 commit intomainfrom
snyk-upgrade-0d56e16f215eda9f75e7540775ca106e

Conversation

@mysommer
Copy link
Copy Markdown
Member

@mysommer mysommer commented Sep 1, 2025

snyk-top-banner

Snyk has created this PR to upgrade @octokit/core from 5.0.1 to 5.2.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 6 versions ahead of your current version.

  • The recommended version was released 2 months ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITREQUEST-8730853
452 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITREQUESTERROR-8730854
452 Proof of Concept
Release notes
Package name: @octokit/core
  • 5.2.2 - 2025-07-11

    5.2.2 (2025-07-11)

    Bug Fixes

    • add createLogger to ensure that pino does not break (#744) (00cc1ea)
  • 5.2.1 - 2025-03-18

    5.2.1 (2025-03-18)

    Bug Fixes

  • 5.2.0 - 2024-04-05
  • 5.1.1 - 2024-04-05
  • 5.1.0 - 2024-01-20
  • 5.0.2 - 2023-11-22
  • 5.0.1 - 2023-09-23
from @octokit/core GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade @octokit/core from 5.0.1 to 5.2.2.

See this package in npm:
@octokit/core

See this project in Snyk:
https://app.snyk.io/org/bysnet/project/d8012074-b4d0-446b-a283-8741d7f78cf5?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @bysnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of the @octokit/core dependency to its latest stable version. The primary goal is to enhance the project's security posture by patching known vulnerabilities and to incorporate recent bug fixes, ensuring the application remains robust and secure.

Highlights

  • Dependency Upgrade: Upgraded the @octokit/core package from version 5.0.1 to 5.2.2.
  • Security Fixes: Addresses two Regular Expression Denial of Service (ReDoS) vulnerabilities, specifically SNYK-JS-OCTOKITREQUEST-8730853 and SNYK-JS-OCTOKITREQUESTERROR-8730854.
  • Bug Fixes: Includes a bug fix in v5.2.2 related to the pino logger integration, as noted in the upstream release notes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@bito-code-review
Copy link
Copy Markdown

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at i@michaelsommer.dev.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades @octokit/core to fix security vulnerabilities. While the upgrade is necessary, it's incomplete and introduces breaking changes. The new version of @octokit/core has a dependency on a new major version of @octokit/types, but other @octokit plugins in this project have not been updated, leading to dependency conflicts. Additionally, a deep import path used in the source code has been removed in the new version, which will cause a build failure. My review provides a critical comment on package.json explaining these issues and outlining the necessary steps for a complete and safe upgrade.

"dependencies": {
"@actions/http-client": "^2.2.0",
"@octokit/core": "^5.0.1",
"@octokit/core": "^5.2.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade is incomplete and introduces breaking changes.

  1. Dependency Conflict: This PR updates @octokit/core, which now depends on @octokit/types@^13.0.0. However, other Octokit plugins in your dependencies (@octokit/plugin-paginate-rest and @octokit/plugin-rest-endpoint-methods) have not been updated and still depend on @octokit/types@^12.0.0. This will install two versions of @octokit/types, which can lead to type incompatibilities and subtle bugs.

  2. Build Failure: The deep import path '@octokit/core/dist-types/types' used in src/github.ts is removed in @octokit/core@5.2.2. This will break the build.

To fix this, you should update all related @octokit packages to versions compatible with @octokit/types@^13.0.0 and fix the broken import path.

A more complete update to your dependencies in package.json would be:

"dependencies": {
  "@actions/http-client": "^2.2.0",
  "@octokit/core": "^5.2.2",
  "@octokit/plugin-paginate-rest": "^9.2.0",
  "@octokit/plugin-rest-endpoint-methods": "^12.0.0"
}

After updating the dependencies, you'll also need to fix the import in src/github.ts (and other files) from:
import {OctokitOptions, OctokitPlugin} from '@octokit/core/dist-types/types'
to:
import type { OctokitOptions, OctokitPlugin } from '@octokit/types'

For this, you should add @octokit/types to your devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants