ZYancey/CSBot/413/TSNativeRoomfinder #414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 22, 2025 20:01
added 6 commits
October 23, 2025 13:03
…-CS-Discord/CSBot into zyancey/CSBot/413/TSNativeRoomfinder
AverageHelper
requested changes
Dec 6, 2025
Contributor
AverageHelper
left a comment
AverageHelper
left a comment
There was a problem hiding this comment.
I'm still going through this, but I found a few things to start with:
| */ | ||
| async function getRoomInfo(yearTerm: string, building: string, room: string): Promise<RoomInfo> { | ||
| const html = await openOrDownloadFile(yearTerm, `${building}-${room}.html`, async () => { | ||
| const response = await axios.post( |
Contributor
There was a problem hiding this comment.
We can avoid the additional dependency on axios if we use the built-in fetch API instead
|
|
||
| ### /scraperooms | ||
|
|
||
| **[Admin Only]** Manually triggers the room finder data scraper to update the database with current semester schedule information. This is useful for forcing an immediate update without waiting for the automatic Sunday schedule. Takes 10-15 minutes to complete and runs in the background. Shows real-time progress if a scrape is already running. |
Contributor
There was a problem hiding this comment.
Suggested change
| **[Admin Only]** Manually triggers the room finder data scraper to update the database with current semester schedule information. This is useful for forcing an immediate update without waiting for the automatic Sunday schedule. Takes 10-15 minutes to complete and runs in the background. Shows real-time progress if a scrape is already running. | |
| **[Admin Only by default]** Manually triggers the room finder data scraper to update the database with current semester schedule information. This is useful for forcing an immediate update without waiting for the automatic Sunday schedule. Takes 10-15 minutes to complete and runs in the background. Shows real-time progress if a scrape is already running. |
| - **between** - Find rooms available during a time range on specific day(s) | ||
| - **when** - Check when a specific room is next available | ||
|
|
||
| The room finder automatically updates its database every Sunday at 2 AM to stay current with the semester schedule. |
Contributor
There was a problem hiding this comment.
Suggested change
| The room finder automatically updates its database every Sunday at 2 AM to stay current with the semester schedule. | |
| The room finder automatically updates its database every Sunday at 2 AM to stay current with the semester schedule. Use [`/scraperooms`](#scraperooms) to update the database manually. |
| .setFooter({ | ||
| text: 'BYU Room Finder', | ||
| // Going to locally host this on my server soon, I'll make that change when I come back and add thumbnails for the building searches | ||
| text: 'BYU Room Finder (Native)', |
Contributor
There was a problem hiding this comment.
normal users don't usually care about this implementation detail, imo
Suggested change
| text: 'BYU Room Finder (Native)', | |
| text: 'BYU Room Finder', |
Comment on lines
+5
to
+7
| SlashCommandSubcommandBuilder, | ||
| SlashCommandStringOption, | ||
| SlashCommandNumberOption, |
Contributor
There was a problem hiding this comment.
Suggested change
| SlashCommandSubcommandBuilder, | |
| SlashCommandStringOption, | |
| SlashCommandNumberOption, | |
| type SlashCommandSubcommandBuilder, | |
| type SlashCommandStringOption, | |
| type SlashCommandNumberOption, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports https://github.com/ZYancey/BYU-Room-Finder-Python-Backend From Postgresql to sqlite to be compatible with our bot's existing DB and ports the entire codebase from Python to Typescript. This was a pain to do but I've done a bunch of testing and the accuracy of the roomfinder actually went up quite a bit as a result of the port.
The scraper is also functional but in an effort to not spam BYU servers, you can seed the scraper folder with this pre-scraped data and it will seed the DB as expected.
scraper.zip
Additionally, now that the scraper lives in CSBot code I added a simple cron to run the scraper at 2am on Sundays, if it is still the same term as the last scrape, it won't pull any new files unless rooms have been added to the schedule. That being said, I also added an admin only scrape command that fires off the scraper manually.
