Add import support for EXT_lights_area#17146
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
sebavan
left a comment
sebavan
left a comment
There was a problem hiding this comment.
Would be awesome to add a test
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17146/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17146/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17146/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
@SergioRZMasson would be great to add the extra shapes, at least the disc ? |
|
cc @bghgary for review |
|
Let me merge and worst case @bghgary will review after :-) |
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Obviously, this is a late review. I have a small comment, and we really should put in a visual test to ensure this extension continues to work.
| } | ||
|
|
||
| /** | ||
| * [Specification](https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Vendor/EXT_lights_area/README.md) |
There was a problem hiding this comment.
Definitely should be marked experimental as the spec hasn't been merged yet. The link also doesn't work.
There was a problem hiding this comment.
Good call. I'll fix this and add a test when I update this importer to match the new spec.
4 participants
Added importing support for first version of EXT_light_area extension.
KhronosGroup/glTF#2525