Convert violation to relative path for subfolder support #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the fix! Ill get this out soon |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add the ability to run
diff-qualityfrom any project subfolder, fixing issue #573.Since internally most of the
diff_covercodebase is aligned to using paths relative to the git root, the most localized way to support relative paths would be to convert the path is inQualityReporter.violations, just before interacting with the violation tool's output (which will be relative to the current working directory).The change in behavior is backward-compatible, and shouldn't introduce any regression.
Note that for SQLFluff this doesn't fix the issue, since SQLFluff doesn't go through
QualityReporter.violations. For SQLFluff, a fix can be implemented in their own implementation ofviolations_batch, or else this logic should be moved to the caller function -BaseReportGenerator._diff_violations- but it feels less natural there, as in the rest of that function's concerns the paths should stay as they are.