Skip to content

move event manager to separate class #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

move event manager to separate class #322

wants to merge 1 commit into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Jan 23, 2018

No description provided.

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 27, 2018

I'm not sure about this... TBH, I think it might be better to move trigger to an importable shared function.

@bekzod
Copy link
Contributor Author

bekzod commented Jan 29, 2018

this didn't affect benchmarks though, but if you think is not worth change you can close it anytime 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bekzod @rwjblue