Skip to content

Remove magic string for IOptions config #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mistyn8 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove magic string for IOptions config #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8993f35
Update NodeDefenderSettings.cs
mistyn8 Jul 5, 2022
fe5c0ea
Remove magic string in Conifg
mistyn8 Jul 5, 2022
b53adae
update to const rather than static
mistyn8 Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Our.Umbraco.NodeDefender/NodeDefender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class NodeDefender : IComposer
public void Compose(IUmbracoBuilder builder)
{
// get all doctypes and node Ids
builder.Services.Configure<NodeDefenderSettings>(builder.Config.GetSection("NodeDefender"));
builder.Services.Configure<NodeDefenderSettings>(builder.Config.GetSection(NodeDefenderSettings.NodeDefender));

builder.AddNotificationHandler<ContentSavingNotification, ContentSavingHandler>();
builder.AddNotificationHandler<ContentMovingToRecycleBinNotification, ContentMovingToRecycleBinHandler>();
Expand Down
4 changes: 3 additions & 1 deletion Our.Umbraco.NodeDefender/NodeDefenderSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ namespace NodeDefender
{
public class NodeDefenderSettings
{
public const string NodeDefender = "NodeDefender"

public IEnumerable<string> AllowedUserGroups { get; set; }
public DenyOptions DenyRename { get; set; }

Expand All @@ -30,4 +32,4 @@ public class ErrorMessage
public string Message { get; set; }
public string Type { get; set; } = EventMessageType.Error.ToString();
}
}
}