Remove run-time chef_gem warnings. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See notes on compile_time at https://docs.chef.io/resource_chef_gem.html#properties.
Author
|
Ah! I see that the Travis build doesn't like my change. I'll take a look at the Travis configs when I have time. |
Author
|
I've made some more changes that are needed to keep the latest Chef DK happy. |
Contributor
|
actually this would prevent us from being able to report on compile time failures no? |
majormoses
suggested changes
Apr 6, 2017
|
|
||
| chef_gem 'hipchat' | ||
| chef_gem 'hipchat' do | ||
| compile_time false if respond_to?(:compile_time) |
Contributor
There was a problem hiding this comment.
This should be true to keep the existing behavior or we can not report on compile time errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See notes on
compile_timeat https://docs.chef.io/resource_chef_gem.html#properties.Hi. I see you have 0.1.9 lined up for release to supermarket. Would you add my small tweak, that kills deprecation warnings on the latest Chef clients, and go ahead with your release, please? I'd like to use your 0.1.9 changes and have my small fix in place too.
Cheers,
Andrew.