Skip to content

Some enhancements for v0.4 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Some enhancements for v0.4 #25

merged 5 commits into from
Aug 21, 2024

Conversation

BatyLeo
Copy link
Owner

@BatyLeo BatyLeo commented Aug 20, 2024

  • precompute useful vertices in constructor
  • optional bounding
  • tests for threshold version

@BatyLeo BatyLeo changed the title Some enhancements Some enhancements for v0.4 Aug 20, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (240e576) to head (0d3b26d).
Report is 29 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (240e576) and HEAD (0d3b26d). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (240e576) HEAD (0d3b26d)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   89.49%   81.97%   -7.53%     
==========================================
  Files           7        6       -1     
  Lines         438      233     -205     
==========================================
- Hits          392      191     -201     
+ Misses         46       42       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BatyLeo BatyLeo linked an issue Aug 20, 2024 that may be closed by this pull request
@BatyLeo BatyLeo marked this pull request as ready for review August 20, 2024 12:37
@BatyLeo BatyLeo merged commit 216e446 into main Aug 21, 2024
3 checks passed
@BatyLeo BatyLeo deleted the enhancements branch August 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional bounding and/or dominance Add tests for the algorithm version with threshold generalized_constrained_shortest_path options
2 participants