Skip to content

Fix server crash when mods.json is empty #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kipstz wants to merge 2 commits into
base: minor
Choose a base branch
from
Open

Fix server crash when mods.json is empty #455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c7491
Fix server crash when mods.json is empty
Kipstz Dec 24, 2025
22a1b96
Merge branch 'BeamMP:minor' into fix-empty-mods-json
Kipstz Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions src/TResourceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,20 @@ void TResourceManager::RefreshFiles() {

nlohmann::json modsDB;

if (std::filesystem::exists(Path + "/mods.json")) {
try {
std::ifstream stream(Path + "/mods.json");
auto modsJsonPath = Path + "/mods.json";
if (std::filesystem::exists(modsJsonPath)) {
if (std::filesystem::file_size(modsJsonPath) > 0) {
try {
std::ifstream stream(modsJsonPath);

stream >> modsDB;
stream >> modsDB;

stream.close();
} catch (const std::exception& e) {
beammp_errorf("Failed to load mods.json: {}", e.what());
stream.close();
} catch (const std::exception& e) {
beammp_errorf("Failed to load mods.json: {}", e.what());
}
} else {
beammp_warn("Mods database file is empty, ignoring it");
}
}

Expand Down Expand Up @@ -220,20 +225,21 @@ void TResourceManager::SetProtected(const std::string& ModName, bool Protected)
try {
nlohmann::json modsDB;

std::fstream stream(modsDBPath);

stream >> modsDB;
if (std::filesystem::file_size(modsDBPath) > 0) {
std::ifstream inStream(modsDBPath);
inStream >> modsDB;
inStream.close();
} else {
beammp_warn("Mods database file is empty, regenerating it");
Copy link
Copy Markdown
Collaborator

@WiserTixx WiserTixx Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be overlooking something here, but is the regeneration code missing?

}

if (modsDB.contains(ModName)) {
modsDB[ModName]["protected"] = Protected;
}

stream.clear();
stream.seekp(0, std::ios::beg);

stream << modsDB.dump(4);

stream.close();
std::ofstream outStream(modsDBPath);
outStream << modsDB.dump(4);
outStream.close();
} catch (const std::exception& e) {
beammp_errorf("Failed to update mods.json: {}", e.what());
}
Expand Down
Loading