Improved palette generation for bammer#2
Open
andrewgardner-beamdog wants to merge 1 commit intomasterfrom
Open
Improved palette generation for bammer#2andrewgardner-beamdog wants to merge 1 commit intomasterfrom
andrewgardner-beamdog wants to merge 1 commit intomasterfrom
Conversation
- fixed issue where opaque black would frequently be left out of palette (causing noticeable problems with shadows in icons) - fixed issue where reserved colors would overwrite first elements of palette - fixed early exit of palette quantize - tweaked palette quantize to improve color selection Also commented out some code not required by bammer that didn't compile as-is
xakbeamdog
approved these changes
May 11, 2021
xakbeamdog
left a comment
xakbeamdog
left a comment
There was a problem hiding this comment.
Looks good more complex review and go too :)
Hopefully I did not miss anything..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also commented out some code not required by bammer that didn't compile as-is