use relative imports inside MDPOW#257
Conversation
orbeckst
commented
Jul 2, 2023
- fix Fix import error in workflows base module (develop branch) #245
- avoid circular imports involving the workflows.registry
- fix #245 - avoid circular imports involving the workflows.registry
|
@cadeduckworth have a look at this PR. These relative imports work, at least in local testing. If this looks good to you, approve and merge. |
Codecov Report
@@ Coverage Diff @@
## develop #257 +/- ##
===========================================
- Coverage 80.74% 80.73% -0.02%
===========================================
Files 15 15
Lines 1906 1905 -1
Branches 294 294
===========================================
- Hits 1539 1538 -1
Misses 276 276
Partials 91 91
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cadeduckworth
left a comment
There was a problem hiding this comment.
Looks good, thank you for catching this!
I noticed things of this nature here and there while reviewing and finishing up #243, probably from early stages of development. Once #243 is merged and we start working on #244 I think that will result in a complete cleanup of the entire workflows module and related test modules.
Reminder, when time allows, there are still issues that exist that require revisiting the analysis modules and tests for revisions mostly required by software package updates (i.e., pytest).