Skip to content

Accept arbitrary args in signal handler #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljwoods2 merged 5 commits into from
Nov 9, 2025
Merged

Accept arbitrary args in signal handler #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1eb0a9
accept arbitrary args in signal handler
ljwoods2 Nov 9, 2025
47d71d1
undo black changes
ljwoods2 Nov 9, 2025
e3154f0
run black (again)
ljwoods2 Nov 9, 2025
d2aab2f
Merge branch 'main' into jupyter-error
ljwoods2 Nov 9, 2025
f2ccf08
update changelog
ljwoods2 Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ The rules for this file:
### Added

### Fixed
* Changed signal handler method to accept arbitrary args to prevent
error being raised in new jupyter version (Issue #116, PR #117)
* Removed timeout changes during pause/resume for IMDv2 and IMv3
(Issue #96, PR #118)

Expand Down
5 changes: 1 addition & 4 deletions imdclient/IMDClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def __init__(
continue_after_disconnect=None,
**kwargs,
):

self._stopped = False
self._conn = self._connect_to_server(host, port, socket_bufsize)
self._imdsinfo = self._await_IMD_handshake()
Expand Down Expand Up @@ -147,7 +146,7 @@ def __init__(

self._producer.start()

def signal_handler(self):
def signal_handler(self, *args, **kwargs):
"""Catch SIGINT to allow clean shutdown on CTRL+C.

This also ensures that main thread execution doesn't get stuck
Expand Down Expand Up @@ -484,7 +483,6 @@ def run(self):
self._buf.notify_producer_finished()

def _expect_header(self, expected_type, expected_value=None):

header = self._get_header()

if header.type != expected_type:
Expand Down Expand Up @@ -934,7 +932,6 @@ def notify_consumer_finished(self):


class IMDFrame:

def __init__(self, n_atoms, imdsinfo):
if imdsinfo.time:
self.time = 0.0
Expand Down
Loading