Conversation
orbeckst
commented
May 2, 2024
- fix Python 3.9 CI failing due to MDAnalysis develop supporting different py than stable #69
- only test Python 3.10 - 3.12
- manually specify versions of MDAnalysis in the test matrix that do not support some of the python versions (see [CookieCutter CI] Decouple "latest" and "develop" MDAnalysis compatibility checks MDAnalysis/cookiecutter-mdakit#110 for background)
- fix #69 - only test Python 3.10 - 3.12 - manually specify versions of MDAnalysis in the test matrix that do not support some of the python versions (see MDAnalysis/cookiecutter-mdakit#110 for background)
|
The CI does not seem to start. The matrix only contains 3.10 / latest instead of 3.11 and 3.12 as well as develop. I checked the gh-ci.yaml in https://rhysd.github.io/actionlint/ and no syntax issues were found. Something similar seems to be happening in #68 where I see the same checks, which is weird, because this PR should run different checks than the other one. |
|
@orbeckst the CI action was disabled because it's not run in so long. I manually re-enabled it (need to go to actions, click on the relevant action and then there's a pop up box to enable it again). I'm going to cycle this PR to get CI running again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 2 2
Lines 59 59
=======================================
Hits 58 58
Misses 1 1 ☔ View full report in Codecov by Sentry. |
IAlibay
left a comment
There was a problem hiding this comment.
Overall lgtm, could you also update the pyproject.toml to reflect the new python range?
IAlibay
left a comment
There was a problem hiding this comment.
just the one thing otherwise lgtm!
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
