This repository was archived by the owner on Jul 11, 2024. It is now read-only.
Add selectors and styles for Jenkins 1.576 UI refresh#5
Open
rpowis wants to merge 1 commit intoBedrockStreaming:masterfrom
Open
Add selectors and styles for Jenkins 1.576 UI refresh#5rpowis wants to merge 1 commit intoBedrockStreaming:masterfrom
rpowis wants to merge 1 commit intoBedrockStreaming:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After updating Jenkins to versions after 1.576, the selectors in the CSS of this plugin weren't targeting the new UI's console pane.
The Jenkins UI was refreshed in this release as per the announcement on their blog, and with it, some of the class names and ids changed in the markup.
This plugin's great, and I got so used to seeing Jenkins console logs in Solarized Dark that when we updated to 1.576 I found it a quite jarring.
Solution