Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

Conversation

@juuuuuu
Copy link

@juuuuuu juuuuuu commented Jun 6, 2019

As noticed in #260 there is an issue when trying to check if a JSON node is null or not.
I'll rather prefer to thow an exception here in order to avoid a "silent" return in a try/catch block.
The PropertyAccessor's getValue() method will throw an throwInvalidArgumentException exception in this case.

Description:
Given I have the following JSON to test, for example (any valid JSON will do the trick):

{
  "fieldA": "toto",
  "fieldB": "tata"
}

And I want to check that "notExistingField" should not be null.
The following step is a success: And the JSON node "notExistingField" should not be null.
I was doing TDD, and I expected my test to fail.

Before I add/update tests, let me know what do you think about it.
Thanks.

@juuuuuu juuuuuu closed this Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant