-
Notifications
You must be signed in to change notification settings - Fork 89
Add QoS configuration to RosNodeParams #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: humble
Are you sure you want to change the base?
Conversation
Hello @tony-p @facontidavide, |
I'm not a maintainer so can't push this further. My first thought was why not define the qos in the node implementation as it will typically be constant for a particular message type, but on reflection I think adding to the params probably does make more sense. |
Hi @facontidavide, |
@rafal-gorecki Would love to get this merged, there is a small fix here to merge into this branch: https://github.com/rafal-gorecki/BehaviorTree.ROS2/pull/1/files. |
Fix createPublisher() call
I merge it, thanks |
I really like this pkg and the way it was created. Bravo to the authors!
The only thing missing is the ability to set QoS for topics.
By the way, I also added the ability to change the qos_profile for services.
I found other solutions with similar themes, which may be updated if this PR passes: