Fix: Type 'GraphQLType' is not assignable to type 'GraphQLOutputType'. module name on Windows#1
Open
rofrol wants to merge 3 commits intoBellk17:masterfrom
Open
Fix: Type 'GraphQLType' is not assignable to type 'GraphQLOutputType'. module name on Windows#1rofrol wants to merge 3 commits intoBellk17:masterfrom
rofrol wants to merge 3 commits intoBellk17:masterfrom
Conversation
Bellk17
reviewed
Jan 29, 2017
| let isMaybe = false | ||
| if (info_type instanceof GraphQLNonNull) { | ||
| info_type = info_type['ofType']; | ||
| //info_type = info_type['ofType']; |
Owner
There was a problem hiding this comment.
This would break the case of Non-Nullable Lists. info_type is assigned what GraphQLNonNull is wrapped around so further checks may be made.
Owner
There was a problem hiding this comment.
I'm looking at rewriting this module in a purely functional manner with full test coverage / better configuration within the next month or so.
Bellk17
reviewed
Jan 29, 2017
| if (field.selectionSet) { | ||
| let isMaybe = false | ||
| if (info_type instanceof GraphQLNonNull) { | ||
| info_type = info_type['ofType'] |
Owner
There was a problem hiding this comment.
Same issue as above. Did you remove this due to an error or were you under the assumption it was vestigial?
Author
There was a problem hiding this comment.
I just wanted to get rid of errors first.
Owner
There was a problem hiding this comment.
What is the error you were getting that this was causing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.