Optimizing prompt job Rest API #9
Open
WeichenXu123 wants to merge 20 commits intoBenWilson2:eval-dataset-unityfrom
Open
Optimizing prompt job Rest API #9WeichenXu123 wants to merge 20 commits intoBenWilson2:eval-dataset-unityfrom
WeichenXu123 wants to merge 20 commits intoBenWilson2:eval-dataset-unityfrom
Conversation
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
TomeHirata
reviewed
Aug 27, 2025
|
Left some comments, but overall looks great! |
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
TomeHirata
reviewed
Sep 2, 2025
TomeHirata
reviewed
Sep 2, 2025
| // Result of the optimization job (only present if status is COMPLETED). | ||
| optional PromptOptimizationResult result = 2; | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe it's worth implementing DELETE /mlflow/optimize-prompt/{job_id} for cancelation as a follow up
Author
There was a problem hiding this comment.
Currently we launch the job in a python thread, we don't have a safe way to kill a python thread, in order to safely cancel job, the job needs to be executed as subprocesses. We can do it as follow-up, if needed.
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
This PR adds optimizing prompt job Rest API
/api/3.0/mlflow/optimize-promptand/api/3.0/mlflow/get-optimize-prompt-job.How is this PR tested?
End-to-end tests:
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
added optimizing prompt job Rest API
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.