Fix placeholders not detecting spawner type correctly + close #138 #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spawner type correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue where the placeholders island_value_ and island_count_ were not correctly identifying the type of spawner, resulting in inaccurate values being returned. The internal logic has been updated to ensure correct type detection and consistent placeholder behavior.
Also, in the previous PR I already added the placeholder for issue #138 I would appreciate it to be closed to avoid confusion or problems.
Instead of using
%Level_[gamemode]_item_in_hand%, the correct placeholder is now:%Level_[gamemode]_island_value_mainhand%This should resolve and close issue #138.