Fix additional anyOf corner cases for Vertex AI Gemini tool calls - issue #11164 #12797
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ericgtkb Bump me once testing is passing 👍 Thanks for this PR! |
|
Looks like tests just passed! @krrishdholakia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some additional anyof corner cases for #11164
In issue #11164 and PR #11195. The fix adds
"title"and"description"back into items in the"anyOf"key for tool calls. However, for cases where neither"title"or"description"exists the fix returns the originalschema_dict.Tool calls that include both
"anyOf"and"default"keys at the same level (without"title"or"description") still result in a Bad Request error.This PR fixes this issue.
Relevant issues
Issue #11164
PR #11195
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Vertex AI anyOf in tool calls
litellm/llms/vertex_ai/common_utils.py: When no"title"or"description"exists we still filter to keep only the"anyOf"key.tests/test_litellm/llms/vertex_ai/gemini/test_vertex_and_google_ai_studio_gemini.py: Added a second test case with only"anyOf"and"default"(without"title"or"description").