First Pass On XML-Based Store Expansions#51
Open
Dargino wants to merge 7 commits intoBetter-Scenes:masterfrom
Open
First Pass On XML-Based Store Expansions#51Dargino wants to merge 7 commits intoBetter-Scenes:masterfrom
Dargino wants to merge 7 commits intoBetter-Scenes:masterfrom
Conversation
Author
|
Also, I suggest exposing the AlertManager class to public so that expansion actions can trigger the Twitch Event letters, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first draft for expanding the silver store with new actions via companion mods.
Action data (title, description, silver cost, etc) are provided via XML, accessible via Rimworld's DefDictionary.
The definition also has a pointer to a class (inheriting from the Action abstract).
This custom action class can be located in the assemblies of any mod loaded after RimConnect (or in RimConnect's own assemblies).
A new list for all custom actions is created, and the action definitions are loaded using the GetAction() function.
The custom actions list is appended to the built-in lists to be added to the silver store.
Everything else is handled by the existing code structure.
I have tested it to the point of working without producing console errors, but rigorous bug testing has not been done.
Also, please review this carefully.. I'm not great with github, so something might be misplaced..