Improve related authorized checks #698
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Reorder authorization check in RelatedCollection
Problem
In
RelatedCollection::forRequest(), theauthorized()method runs beforeinRequest(), causing authorization checks on ALL related fields defined in a repository, even when only a subset is requested.Example: A repository with 9 related fields (activities, contacts, invoices, notes, addresses, etc.) will authorize all 9 fields even when the request only includes
?related=addresses.With 50 items per page, this results in 450 authorization checks instead of 50.
For example
/restify/customers?related=addressesif the customer repository had 10 relationships, it would go through other relationships and to authorized checks even if those relationships are no part of the request.Solution
Swap the order so filtering happens before authorization:
Impact