Skip to content

Add rotation parameter to CameraDetails#56

Open
Felforge wants to merge 5 commits intomainfrom
camera-rotation-parameter
Open

Add rotation parameter to CameraDetails#56
Felforge wants to merge 5 commits intomainfrom
camera-rotation-parameter

Conversation

@Felforge
Copy link
Copy Markdown

  • Added int32 rotation field (field 17) to CameraDetails message
  • Rotation is specified in degrees for camera orientation control
  • Updated version to 1.3

- Added int32 rotation field (field 17) to CameraDetails message
- Rotation is specified in degrees for camera orientation control
- Updated version to 1.3
Copy link
Copy Markdown
Member

@Gold872 Gold872 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change but it looks good

int32 stream_height = 16;

/// Number of 90 degrees rotation increments
int32 rotationQuarters = 17;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int32 rotationQuarters = 17;
int32 rotation= 17;

Just calling it rotation should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants