Moved the *.tpp includes from the .h to the .cpp.#16
Open
aroy-hc wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Open
Moved the *.tpp includes from the .h to the .cpp.#16aroy-hc wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
aroy-hc wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Conversation
melund
added a commit
to melund/BTKCore
that referenced
this pull request
Dec 3, 2019
…' into integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It is my first time creating a pull request on a public project, so I am not sure how to write the message. Here's a brief description of the changes.
I moved the lines to include the *.tpp from the .h to the .cpp.
This was done to remove the templates from the public interface when dynamic linking to the library.
see this post for more information: https://groups.google.com/forum/?hl=fr#!topic/btk-users/BQECOfzjuxQ
Best regards,
Alex