Added support for SWIG/Eigen type conversion for int & float matrices.#21
Open
rwpenney wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Open
Added support for SWIG/Eigen type conversion for int & float matrices.#21rwpenney wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
rwpenney wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "eigen.i" file is a very valuable resource for other projects that need to pass Eigen::MatrixXd matrices between C++ & Python via SWIG. Unfortunately, it currently only supports the exchange of matrices containing double-precision elements, corresponding to the Eigen::MatrixXd datatype.
This patch adds support for passing matrices of integers and floats, which represent the other major datatypes supported by the Eigen library. The patch should allow passing Eigen::MatrixXi and MatrixXf datatypes between C++ & Python.
The patch also tidies a small amount of unnecessary whitespace and semicolons.