Support building for Python 3#26
Open
allardhoeve wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Open
Support building for Python 3#26allardhoeve wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
allardhoeve wants to merge 1 commit intoBiomechanical-ToolKit:masterfrom
Conversation
Author
|
Any chance of this going in @Alzathar? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library just works for Python 3, but the compilation has a small problem with
printno longer being a keyword but a function. This makes it so that CMAKE thinksnumpyis not installed.So this PR changes the CMAKE instructions needed to find
numpyso that they work on both Python 3 and Python 2.Note that Python 2.7 will be end-of-life in about seven months, so getting Python 3 support in is pretty important. Luckily it seems to be very easy.