Introduce Valkey Vector Store for LangChain AWS #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasHowellYopp
left a comment
MatthiasHowellYopp
left a comment
There was a problem hiding this comment.
Minor questions - basically looks good.
| print(f" Score: {score:.4f}") | ||
| print(f" Metadata: {doc.metadata}\n") | ||
|
|
||
| # Example with filtering (if filters are implemented) |
There was a problem hiding this comment.
do we not know if filters are implemented? or this depends on some other variable implementation that may or may not be present?
There was a problem hiding this comment.
don't know enough about python to know if an empty init file makes sense or not.
Jonathan-Improving
force-pushed
the
feature/vs/valkey
branch
from
94672a2 to
456c553
Compare
Jonathan-Improving
force-pushed
the
feature/vs/valkey
branch
from
456c553 to
07e6ebf
Compare
daric93
reviewed
Feb 2, 2026
| name: str = Field(...) | ||
|
|
||
|
|
||
| class TextFieldSchema(ValkeyField): |
There was a problem hiding this comment.
Valkey doesn't support TEXT field yet. How does the schema creation work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, set for merging into another temporary branch (for now) for the primary purpose of collecting initial feedback from internal BitQuill developers before promoting it to the LangChain team.
See also the Valkey Vector Store GH Issue for tracking purposes.