Skip to content

fix(sdk-coin-rune): rename thorchain:rune to tthorchain:rune #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhavidhingra merged 1 commit into from
Nov 12, 2024
Merged

fix(sdk-coin-rune): rename thorchain:rune to tthorchain:rune #5122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/bitgo/src/v2/coinFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ function registerCoinConstructors(globalCoinFactory: CoinFactory): void {
globalCoinFactory.register('tosmo', Tosmo.createInstance);
globalCoinFactory.register('tpolygon', Tpolygon.createInstance);
globalCoinFactory.register('trbtc', Trbtc.createInstance);
globalCoinFactory.register('thorchain:trune', Trune.createInstance);
globalCoinFactory.register('tthorchain:rune', Trune.createInstance);
globalCoinFactory.register('trx', Trx.createInstance);
globalCoinFactory.register('tsei', Tsei.createInstance);
globalCoinFactory.register('tsol', Tsol.createInstance);
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-rune/src/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import { Trune } from './trune';

export const register = (sdk: BitGoBase): void => {
sdk.register('thorchain:rune', Rune.createInstance);
sdk.register('thorchain:trune', Trune.createInstance);
sdk.register('tthorchain:rune', Trune.createInstance);
};
6 changes: 3 additions & 3 deletions modules/sdk-coin-rune/test/unit/rune.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ describe('Rune', function () {
before(function () {
bitgo = TestBitGo.decorate(BitGoAPI, { env: 'mock' });
bitgo.safeRegister('thorchain:rune', Rune.createInstance);
bitgo.safeRegister('thorchain:trune', Trune.createInstance);
bitgo.safeRegister('tthorchain:rune', Trune.createInstance);
bitgo.initializeTestVars();
rune = bitgo.coin('thorchain:rune');
trune = bitgo.coin('thorchain:trune');
trune = bitgo.coin('tthorchain:rune');
mainnetUtils = new RuneUtils(NetworkType.MAINNET);
testnetUtils = new RuneUtils(NetworkType.TESTNET);
});
Expand All @@ -33,7 +33,7 @@ describe('Rune', function () {
rune.getFullName().should.equal('Rune');
rune.getBaseFactor().should.equal(1e8);

trune.getChain().should.equal('thorchain:trune');
trune.getChain().should.equal('tthorchain:rune');
trune.getFamily().should.equal('thor');
trune.getFullName().should.equal('Testnet Rune');
trune.getBaseFactor().should.equal(1e8);
Expand Down
10 changes: 5 additions & 5 deletions modules/sdk-coin-rune/test/unit/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as testData from '../resources/trune';

describe('Rune Transaction', () => {
let tx: CosmosTransaction;
const config = coins.get('thorchain:trune');
const config = coins.get('tthorchain:rune');
const utils = new RuneUtils(config.network.type);

beforeEach(() => {
Expand Down Expand Up @@ -49,14 +49,14 @@ describe('Rune Transaction', () => {
{
address: bech32.decode(testData.TEST_SEND_TX.sender).data,
value: testData.TEST_SEND_TX.sendMessage.value.amount[0].amount,
coin: 'thorchain:trune',
coin: 'tthorchain:rune',
},
]);
should.deepEqual(tx.outputs, [
{
address: bech32.decode(testData.TEST_SEND_TX.sendMessage.value.toAddress).data,
value: testData.TEST_SEND_TX.sendMessage.value.amount[0].amount,
coin: 'thorchain:trune',
coin: 'tthorchain:rune',
},
]);
});
Expand Down Expand Up @@ -86,14 +86,14 @@ describe('Rune Transaction', () => {
{
address: bech32.decode(testData.TEST_SEND_TX.sender).data,
value: testData.TEST_SEND_TX.sendMessage.value.amount[0].amount,
coin: 'thorchain:trune',
coin: 'tthorchain:rune',
},
]);
should.deepEqual(tx.outputs, [
{
address: bech32.decode(testData.TEST_SEND_TX.sendMessage.value.toAddress).data,
value: testData.TEST_SEND_TX.sendMessage.value.amount[0].amount,
coin: 'thorchain:trune',
coin: 'tthorchain:rune',
},
]);
});
Expand Down
4 changes: 2 additions & 2 deletions modules/sdk-coin-rune/test/unit/transactionBuilder/transactionBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ describe('Rune Transaction Builder', async () => {
before(function () {
bitgo = TestBitGo.decorate(BitGoAPI, { env: 'mock' });
bitgo.safeRegister('thorchain:rune', Rune.createInstance);
bitgo.safeRegister('thorchain:trune', Trune.createInstance);
bitgo.safeRegister('tthorchain:rune', Trune.createInstance);
bitgo.initializeTestVars();
basecoin = bitgo.coin('thorchain:trune');
basecoin = bitgo.coin('tthorchain:rune');
factory = basecoin.getBuilder();
});

Expand Down
4 changes: 2 additions & 2 deletions modules/sdk-coin-rune/test/unit/transactionBuilder/transferBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ describe('Rune Transfer Builder', () => {
before(function () {
bitgo = TestBitGo.decorate(BitGoAPI, { env: 'mock' });
bitgo.safeRegister('thorchain:rune', Rune.createInstance);
bitgo.safeRegister('thorchain:trune', Trune.createInstance);
bitgo.safeRegister('tthorchain:rune', Trune.createInstance);
bitgo.initializeTestVars();
basecoin = bitgo.coin('thorchain:trune');
basecoin = bitgo.coin('tthorchain:rune');
factory = basecoin.getBuilder();
testTx = testData.TEST_SEND_TX;
testTxWithMemo = testData.TEST_TX_WITH_MEMO;
Expand Down
2 changes: 1 addition & 1 deletion modules/statics/src/coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,7 @@ export const coins = CoinMap.fromCoins([
),
account(
'7281ab3b-0451-4ef9-b367-8623d9bcfd87',
'thorchain:trune',
'tthorchain:rune',
'Testnet Rune',
Networks.test.rune,
8,
Expand Down
4 changes: 2 additions & 2 deletions modules/statics/test/unit/fixtures/expectedColdFeatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export const expectedColdFeatures = {
'kava',
'near',
'osmo',
'thorchain:rune',
'sei',
'sol',
'sui',
Expand All @@ -87,16 +86,17 @@ export const expectedColdFeatures = {
'tcoreum',
'tdot',
'thash',
'thorchain:rune',
'tia',
'tislm',
'tinjective',
'tkava',
'tnear',
'tosmo',
'thorchain:trune',
'tsei',
'tsol',
'tsui',
'tthorchain:rune',
'ttia',
'tzeta',
'ton',
Expand Down