feat(express): migrate verifycoinaddress to typed routes #6940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhao122
force-pushed
the
WP-5436-express-migrate-api-v2-coin-verifyaddress-to-typed-routes
branch
3 times, most recently
from
cb61e72 to
579bb0d
Compare
danielzhao122
force-pushed
the
WP-5436-express-migrate-api-v2-coin-verifyaddress-to-typed-routes
branch
from
579bb0d to
7b55f11
Compare
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
For the JSdocs, use spec/services/platform.yaml in WP as a reference point, this where are our existing api-docs for express are. They might be outdated for some newer fields, but for the existing ones, lets use the same docs so that the change from the manual spec to the auto generated ones can be seamless
zahin-mohammad
previously approved these changes
Sep 10, 2025
SimonVutovB
previously approved these changes
Sep 10, 2025
TICKET: WP-5436 Co-authored-by: Zahin Mohammad <zahinmohammad@bitgo.com>
danielzhao122
dismissed stale reviews from SimonVutovB and zahin-mohammad
via
0491a83
kaustubhbitgo
approved these changes
Sep 11, 2025
zahin-mohammad
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed router for verifycoinaddress.
Added UT: "express.verifycoinaddress" in test/unit/typedRoutes/decode.ts
Ticket: https://bitgoinc.atlassian.net/browse/WP-5436