Add ENTERPRISE_PAYS_FEES and accountExplorerUrl #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common use case in the front end is building a URL to a block explorer for a specific transaction, so a user can see the status of their transaction on chain. For some account coins, fees are paid from the Enterprise, instead of from the wallet itself. For those coins, we'd like to be able to: 1) Know that this is one of those coins where the enterprise pays fees 2) How to build an explorer URL so a user can look at the on chain balance of their Enterprise fee address This commit adds the ENTEPRISE_PAYS_FEES coin feature, and adds this feature to XTZ and ETH (the only two coins which currently pay fees from the Enterprise gas tank). This solves for case #1. This commit also adds a new optional field to `AccountNetwork` called `accountExplorerUrl`. This can be used for building urls just like the `explorerUrl`, and therefore solves case #2 above. Ticket: BG-19107
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
===========================================
+ Coverage 36.38% 55.68% +19.29%
===========================================
Files 79 80 +1
Lines 8937 8942 +5
Branches 1781 1781
===========================================
+ Hits 3252 4979 +1727
+ Misses 5177 3264 -1913
- Partials 508 699 +191
Continue to review full report at Codecov.
|
bitgoAaron
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common use case in the front end is building a URL to a block explorer
for a specific transaction, so a user can see the status of their
transaction on chain.
For some account coins, fees are paid from the Enterprise, instead of
from the wallet itself. For those coins, we'd like to be able to:
balance of their Enterprise fee address
This commit adds the ENTEPRISE_PAYS_FEES coin feature, and adds this
feature to XTZ and ETH (the only two coins which currently pay fees from
the Enterprise gas tank). This solves for case #1.
This commit also adds a new optional field to
AccountNetworkcalledaccountExplorerUrl. This can be used for building urls just like theexplorerUrl, and therefore solves case #2 above.Ticket: BG-19107