feat(sdk-core): update wallet sharing for multi-user-key #7529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
margueriteblair
left a comment
margueriteblair
left a comment
There was a problem hiding this comment.
changes look good, i'd just fix the failing ci
zahin-mohammad
force-pushed
the
WP-6790/update-walllet-share-wallet
branch
from
7dd8c3a to
d594ecf
Compare
zahin-mohammad
requested review from
margueriteblair,
mohammadalfaiyazbitgo and
pranavjain97
mohammadalfaiyazbitgo
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates wallet sharing to handle multi-user-key OFC wallets. When wallets support
multi-user-key, wallet shares do not require to share the keychain with the receiver.WP-6790