fix(wallet-key-share): Optimize createBulkWalletShare to Fetch Keychain Once and Prevent Rate Limiting #7849
+217
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abk404
changed the title
sdoshibitgo
reviewed
Jan 6, 2026
| bulkCreateShareOptions.push({ | ||
| user: shareOption.userId, | ||
| permissions: shareOption.permissions, | ||
| keychain: sharedKeychain as BulkWalletShareKeychain, |
Contributor
There was a problem hiding this comment.
Missing validation: The original code had explicit assertions for keychain fields. Consider keeping runtime validation instead of relying solely on type cast.
Author
There was a problem hiding this comment.
makes sense, added the explicit assertions and removed the typecast completely.
| */ | ||
| async getDecryptedKeychainForSharing( | ||
| walletPassphrase: string | undefined | ||
| ): Promise<{ prv: string; pub: string } | undefined> { |
Contributor
There was a problem hiding this comment.
Type improvement: Consider extracting { prv: string; pub: string } into a named interface for reusability.
| path: user.path, | ||
| }, | ||
| })), | ||
| }); |
Contributor
There was a problem hiding this comment.
Expand test coverage: Also verify encryptPrvForUser is called once per user to ensure encryption happens for each recipient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CSI-1548
Type of change
Summary
Optimizes
createBulkWalletShareto fetch the wallet keychain only once instead of once per user, drastically reducing API calls and preventing rate limiting (HTTP 429) errors during bulk wallet sharing.Problem
When sharing a wallet with multiple users via
createBulkWalletShare, the SDK was fetching the wallet keychain (v2.key.get) for each user in the share list.For example, sharing 26 wallets with 15 users each resulted in 390 API calls (26 × 15), causing rate limiting errors and failures with the message: "Failed to process wallet shares after retrying with single requests."
Check the support ticket : CS-6701
Solution
Refactored the code to:
Extract common logic into two new helper methods:
getDecryptedKeychainForSharing()- Fetches and decrypts the keychain onceencryptPrvForUser()- Encrypts the private key for a specific user (no API calls)Optimize
createBulkWalletShare()to fetch the keychain once before the loop, then reuse it for all users