feat(wasm-utxo): update rust-miniscript to v13.0.0-opdrop with API compatibility #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates miniscript dependency from v12.3.4-opdrop to v13.0.0-opdrop and adapts code to API changes. Key changes include: - Updated TapTree representation and handling - Renamed `parse` method to `decode` for scripts - Changed `output_key().to_inner()` to `output_key().to_x_only_public_key()` - Updated error type from `ConversionError` to `NonDefiniteKeyError` Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
Implements a RecursiveTapTree type to maintain compatibility with previous API after the upstream rust-miniscript library removed the recursive tap tree structure in favor of a flat representation. Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
Update Rust crate dependencies in the project, including critical libraries like bitcoin_hashes, bech32, and wasm-bindgen. Added configuration in deny.toml to handle hex-conservative duplicate versions. Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rust-miniscript dependency from v12.3.4-opdrop to
v13.0.0-opdrop and adapts our code to handle the API changes while
maintaining backwards compatibility:
parsemethod todecodefor scriptsoutput_key().to_inner()tooutput_key().to_x_only_public_key()ConversionErrortoNonDefiniteKeyErrorprevious API after upstream removed the recursive tap tree structure
BTC-2656