feat: setup enclaved bitgo express with mTLS support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavjain97
force-pushed
the
WP-4352-setup-enclaved-bitgo-express
branch
from
46b3862 to
442c3ce
Compare
pranavjain97
requested review from
a team,
islamaminBitGo,
lokesh-bitgo,
mohammadalfaiyazbitgo and
ranga-r2
and removed request for
a team
pranavjain97
changed the title
pranavjain97
force-pushed
the
WP-4352-setup-enclaved-bitgo-express
branch
from
ef5c5a1 to
1e7dbfd
Compare
pranavjain97
force-pushed
the
WP-4352-setup-enclaved-bitgo-express
branch
from
1e7dbfd to
daaa741
Compare
Ticket: WP-4352
pranavjain97
force-pushed
the
WP-4352-setup-enclaved-bitgo-express
branch
2 times, most recently
from
0bbe17d to
efe92c4
Compare
pranavjain97
force-pushed
the
WP-4352-setup-enclaved-bitgo-express
branch
from
efe92c4 to
00bdafa
Compare
pranavjain97
changed the title
| } | ||
|
|
||
| const fingerprint = clientCert.fingerprint256?.replace(/:/g, '').toUpperCase(); | ||
| if (!fingerprint || !config.mtlsAllowedClientFingerprints?.includes(fingerprint)) { |
There was a problem hiding this comment.
nice. this way our clients can use this in an even more secure way and restrict the certificates to ones they generate internally for usage only by express nodes
mohammadalfaiyazbitgo
approved these changes
May 22, 2025
|
|
||
| ## License | ||
|
|
||
| MIT |
Contributor
There was a problem hiding this comment.
do we have guidance/approval to use mit licesense ?
islamaminBitGo
approved these changes
May 22, 2025
islamaminBitGo
left a comment
islamaminBitGo
left a comment
There was a problem hiding this comment.
LGTM overall, not seeing tests for mTLS setup with client and server certs and a constrained list of accepted certs by the server?
Contributor
Author
Yeah its only setup for dev/test env's rn. We can add those easily later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP-4352