feat: package master bitgo express with enclaved express #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavjain97
changed the title
pranavjain97
requested review from
islamaminBitGo,
mohammadalfaiyazbitgo and
zahin-mohammad
mohammadalfaiyazbitgo
approved these changes
May 28, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
some typing nits which we can handle in a follow up.
| console.log('Starting in Master Express mode...'); | ||
| await masterExpressApp.init(); | ||
| } else { | ||
| throw new Error(`Unknown app mode: ${(cfg as any).appMode}`); |
Contributor
There was a problem hiding this comment.
you don't need this if config() returns Config
| */ | ||
| export function createErrorHandler(debugLogger: debug.Debugger) { | ||
| return function ( | ||
| err: any, |
Contributor
There was a problem hiding this comment.
nit: should be unknown
| }); | ||
|
|
||
| // Set timeout | ||
| app.use(timeout(config.timeout) as any); |
Contributor
There was a problem hiding this comment.
can we avoid type casting here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-4583
This updates the enclaved bitgo express to include the base master bitgo express functionality as well.
Both of them have seperate configs and can be run separately, but share some common setup.
This only implements the /ping APIs.
curl -k https://localhost:3080/ping/enclavedExpress-> This calls MBE running on3080, which pings enclaved express. Added README on how to setup/run both of them.Note: This repo will be renamed to
advanced-key-management-express