Skip to content

229 statusquotepage optimize this with pagination or batch fetching if api supports it#243

Open
JulianVIE wants to merge 6 commits intodevfrom
229-statusquotepage---optimize-this-with-pagination-or-batch-fetching-if-api-supports-it
Open

229 statusquotepage optimize this with pagination or batch fetching if api supports it#243
JulianVIE wants to merge 6 commits intodevfrom
229-statusquotepage---optimize-this-with-pagination-or-batch-fetching-if-api-supports-it

Conversation

@JulianVIE
Copy link

No description provided.

@JulianVIE JulianVIE self-assigned this Mar 4, 2026
Copilot AI review requested due to automatic review settings March 4, 2026 14:58
@JulianVIE JulianVIE changed the base branch from dev to 237-remove-enable-minting-button March 4, 2026 14:59
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 57.81250% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.33%. Comparing base (346440b) to head (b1af568).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/quotes/StatusQuotePage.tsx 57.81% 27 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           237-remove-enable-minting-button     #243      +/-   ##
====================================================================
- Coverage                             74.27%   73.33%   -0.94%     
====================================================================
  Files                                    32       33       +1     
  Lines                                  1104     1189      +85     
  Branches                                446      472      +26     
====================================================================
+ Hits                                    820      872      +52     
- Misses                                  275      308      +33     
  Partials                                  9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the quotes UI and generated API client to align with backend changes around minting/token status, while reducing per-render query load on the status quotes list.

Changes:

  • Add paging controls to StatusQuotePage and limit per-quote detail queries to the visible slice.
  • Remove “enable minting” mutation/action wiring and update UI logic to use MintingEnabled status and fee token checks.
  • Regenerate OpenAPI-derived client/types (remove enable-mint endpoint, add token status endpoint, update discriminants) and adjust ignore rules for backup OpenAPI files.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/pages/quotes/components/useQuoteMutations.ts Removes enable-minting mutation and handler, keeps deny/offer/request-to-pay flows.
src/pages/quotes/StatusQuotePage.tsx Adds paging state/UI and changes listQuotes query to use date filter + slicing for visible items.
src/pages/quotes/QuotePage.tsx Updates status handling to MintingEnabled, adds fee token extraction and token-status checks.
src/pages/quotes/QuoteActions.tsx Removes enable-minting UI/props and narrows flows to accepted/minting-enabled states.
src/generated/client/types.gen.ts Regenerates types: removes enable-minting types, updates discriminants/status, adds token status types.
src/generated/client/sdk.gen.ts Regenerates SDK: removes enable-minting call, adds token status call, reorders exports.
src/generated/client/index.ts Updates exports to match regenerated SDK/types.
src/generated/client/client/client.gen.ts Adds a TODO comment in generated client error path.
src/generated/client/@tanstack/react-query.gen.ts Regenerates react-query wrappers: removes enable-minting mutation, adds token status mutation, reorders.
opt/wildcat/openapi.json OpenAPI spec updates (token_status endpoint, remove enable_mint, status enum changes).
opt/wildcat/backup/_openapi.json Backup OpenAPI changes (tracked file).
.gitignore Adds redundant ignore entry for /opt/wildcat/backup/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from 237-remove-enable-minting-button to dev March 5, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants