Conversation
chouettevan
force-pushed
the
pypy3-build-tools
branch
13 times, most recently
from
8588dd1 to
1d33ba2
Compare
chouettevan
force-pushed
the
pypy3-build-tools
branch
from
1d33ba2 to
1f945dc
Compare
noraj
left a comment
noraj
left a comment
There was a problem hiding this comment.
I'm not sure to understand the changes on packages/pypy3-flit-core/PKGBUILD?
the version of pypy in arch linux is pypy 3.11, whose site packages are on /opt/pypy3/lib/pypy3_3.11/ .this change ensures |
chouettevan
force-pushed
the
pypy3-build-tools
branch
3 times, most recently
from
a75591c to
4608629
Compare
chouettevan
force-pushed
the
pypy3-build-tools
branch
2 times, most recently
from
187c997 to
97d02e5
Compare
|
why has this not been merged? Is there something wrong with my PR? |
|
I only did pre-review. noptrix must be busy. |
| arch=('any') | ||
| url='https://github.com/pypa/flit' | ||
| license=('BSD-3-Clause') | ||
| depends=('python' 'pypy3') |
There was a problem hiding this comment.
can you please leave 'python' here?
There was a problem hiding this comment.
It is not necessary, but if you want to,why not?
packages/pypy3-setuptools/PKGBUILD
Outdated
| pkgver=80.9.0 | ||
| pkgrel=1 | ||
| epoch=1 | ||
| pkgdesc="Easily download, build, install, upgrade, and uninstall Python packages" |
There was a problem hiding this comment.
please use single quotes unless single quote is used inside the description. please use a dot at the end.
packages/pypy3-setuptools/PKGBUILD
Outdated
| epoch=1 | ||
| pkgdesc="Easily download, build, install, upgrade, and uninstall Python packages" | ||
| arch=(any) | ||
| url="https://${_pkgname}.pypa.io" |
There was a problem hiding this comment.
URL without variables please
packages/pypy3-setuptools/PKGBUILD
Outdated
| cd "${srcdir}"/${_pkgname}-${pkgver} | ||
| sed -i -e "s|^#\!.*/usr/bin/env python|#!/usr/bin/env pypy|" setup.py |
There was a problem hiding this comment.
remove $srcdir here. not needed
| } | ||
|
|
||
| # Rename the following function to check() to enable checking | ||
| _check() { |
There was a problem hiding this comment.
we don't use check() functions. remove it please
There was a problem hiding this comment.
why not? check() functions can be useful to detect missing dependencies,especially in interpereted languages like python,where a missing package will not cause a build error,but a runtime error.
packages/pypy3-setuptools/PKGBUILD
Outdated
|
|
||
| package() { | ||
| depends=(pypy3) | ||
| cd "${srcdir}/${_pkgname}-${pkgver}" |
noptrix
left a comment
noptrix
left a comment
There was a problem hiding this comment.
thanks for this PR. please have a look on my review.
|
Most changes have been made.all requests for modifications have been answered to |
3 participants
This PR adds part of the pypy build system. specifically, the packages included here are those who do not depend on anything other than pypy3-flit-core. the rest of the build system should be added in a subsequent PR. this PR follows #4813 and should eventually allow pypy-angr to be integrated to blackarch linux