Skip to content

Conversation

@Treshank
Copy link
Contributor

@Treshank Treshank commented Sep 1, 2025

No description provided.

@vercel
Copy link

vercel bot commented Sep 1, 2025

@Treshank is attempting to deploy a commit to the Ram Shankar's projects Team on Vercel.

A member of the Team first needs to authorize it.

# Conflicts:
#	packages/unit-conversion/src/constants/labels.ts
#	packages/unit-conversion/src/constants/units.ts
#	packages/unit-conversion/src/utils/common.ts
#	packages/unit-conversion/src/utils/conversion-factors.ts
Copy link
Owner

@BlankRiser BlankRiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also create the documentation pages by creating a force.mdx file within apps/docs/src/content/docs/conversions/ folder. Look at the contents of other files files to document force unit.

@Treshank Treshank requested a review from BlankRiser September 16, 2025 18:38
Copy link
Owner

@BlankRiser BlankRiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix code quality checks.
You can run biome locally to check the warnings/errors.

@Treshank Treshank requested a review from BlankRiser September 20, 2025 05:41
Copy link
Owner

@BlankRiser BlankRiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@BlankRiser BlankRiser merged commit 9d3753a into BlankRiser:main Sep 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants