-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add force units. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Treshank is attempting to deploy a commit to the Ram Shankar's projects Team on Vercel. A member of the Team first needs to authorize it. |
# Conflicts: # packages/unit-conversion/src/constants/labels.ts # packages/unit-conversion/src/constants/units.ts # packages/unit-conversion/src/utils/common.ts # packages/unit-conversion/src/utils/conversion-factors.ts
BlankRiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also create the documentation pages by creating a force.mdx file within apps/docs/src/content/docs/conversions/ folder. Look at the contents of other files files to document force unit.
BlankRiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix code quality checks.
You can run biome locally to check the warnings/errors.
BlankRiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.