Implement audio beacon cadence configurability#10
Open
caturria wants to merge 1 commit intoBlindGuyNW:devfrom
Open
Implement audio beacon cadence configurability#10caturria wants to merge 1 commit intoBlindGuyNW:devfrom
caturria wants to merge 1 commit intoBlindGuyNW:devfrom
Conversation
…o ModMenu that intentionally lacks toggle. Remove hardcoded constraints on beacons in AudioLoopManager.
BlindGuyNW
requested changes
Apr 11, 2026
Owner
BlindGuyNW
left a comment
There was a problem hiding this comment.
Thanks for this contribution, Jordan! The feature is well-scoped and the SliderItem refactor is clean. Just a few minor fixes needed before merging.
| continue; | ||
| } | ||
| nextBeaconTime = Time.time + BEACON_INTERVAL; | ||
| nextBeaconTime = Time.time + (0.1f + (PreferencesManager.BeaconDelay / 25f)); |
Owner
There was a problem hiding this comment.
The 25f divisor and 0.1f floor are a bit opaque here. Could you extract this into a local variable with a short comment explaining the range?
Suggested change
| nextBeaconTime = Time.time + (0.1f + (PreferencesManager.BeaconDelay / 25f)); | |
| nextBeaconTime = Time.time + (0.1f + (PreferencesManager.BeaconDelay / 25f)); // Slider 0-100 maps to 100ms-4100ms |
Or pull the expression into a named variable — either works.
| new ToggleItem("Audio Beacons", | ||
| () => FFVI_ScreenReaderMod.AudioBeaconsEnabled, | ||
| () => FFVI_ScreenReaderMod.Instance?.ToggleAudioBeacons()), | ||
| new SliderItem("Beacon delay", |
Owner
There was a problem hiding this comment.
Two things here:
- Title case: All other menu items use title case (
"Audio Beacons","Beacon Volume"), so this should be"Beacon Delay". - Indentation: The leading spaces and continuation lines are off compared to surrounding entries. Should match:
Suggested change
| new SliderItem("Beacon delay", | |
| new SliderItem("Beacon Delay", | |
| () => PreferencesManager.BeaconDelay, | |
| PreferencesManager.SetBeaconDelay), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Usage
Implementation details
Critique welcome
Disclosure: C# is not my forte. I learned enough of it to pass two college courses years ago and haven't worked in it since. I'm happy to make revisions as you see fit.
Thank you for your consideration, and for this wonderful project!