add breakpad crash handler for Windows #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for windows only? |
|
Where will report go? |
rkitover
force-pushed
the
qt-breakpad
branch
from
1ef0c55 to
e601865
Compare
|
The breakpad sources are a git submodule, they are not included. This is for Windows only yes. The report is form data posted to a URL, the receiving app has not been set up yet. |
|
rkitover
force-pushed
the
qt-breakpad
branch
from
e601865 to
6b4540f
Compare
|
Yes I tested it for signer, I can't give you a screenshot now but I'll give you a screenshot for terminal: You can test it by just making it crash, e.g. like this: QTimer::singleShot(10000, []{ int *a = (int*)0x42; printf("%d", *a); }) // or anything that will crashBy qt sources, you mean what's in qt creator? That's what the qt-breakpad demo is based on, and I got the code from the demo. I haven't looked at what's in qt creator currently. I'm going to do a bit more work on this to wrap some things up. |
rkitover
force-pushed
the
qt-breakpad
branch
from
6b4540f to
b68a017
Compare
|
I made a change to always enable the systray cleanup code even when the crash handler is not in effect, Scott wanted this. |
rkitover
force-pushed
the
qt-breakpad
branch
2 times, most recently
from
4138c8a to
85a82b0
Compare
Integrate and modify code from this demo: https://github.com/KandaoVR/qt-breakpad Use the latest version of breakpad with the cmake file from the vcpkg port. To enable the crash handler, pass the cmake option to `generate.py`, e.g.: ```bash python ./generate.py -cmake-flags '-DENABLE_CRASH_HANDLER=ON' release ``` It will then be activated for both the terminal and the signer. When `OFF` breakpad will still be in effect to launch the systray cleanup code, but the crash handler will not display. I am working on the report receiver web app here: https://github.com/rkitover/qt-breakpad-web TODO: - see if mac and linux can work Signed-off-by: Rafael Kitover <rkitover@gmail.com>
rkitover
force-pushed
the
qt-breakpad
branch
from
85a82b0 to
961fa0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add breakpad crash handler for Windows
Integrate and modify code from this demo:
https://github.com/KandaoVR/qt-breakpad
Use the latest version of breakpad with the cmake file from the vcpkg
port.
To enable the crash handler, pass the cmake option to
generate.py,e.g.:
python ./generate.py -cmake-flags '-DENABLE_CRASH_HANDLER=ON' releaseIt will then be activated for both the terminal and the signer.
When
OFFbreakpad will still be in effect to launch the systraycleanup code, but the crash handler will not display.
TODO:
find or write submit URL handler
see if mac and linux can work
Signed-off-by: Rafael Kitover rkitover@gmail.com