feet:add increase counter#3
Open
NUMBER72857 wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
Open
feet:add increase counter#3NUMBER72857 wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
NUMBER72857 wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
Conversation
Abeeujah
requested changes
Feb 24, 2025
| function transferOwnership(address _newOwner) public onlyOwner { | ||
| require(_newOwner != address(0), "Invalid address"); | ||
| owner = _newOwner; | ||
| } |
Collaborator
There was a problem hiding this comment.
You could emit a TransferOwnership event ☘️
| require(bytes(_newName).length > 0, "Name cannot be empty"); | ||
| students[msg.sender].name = _newName; | ||
| } | ||
| } No newline at end of file |
| /// @param _value The amount to increase the counter by. | ||
| function increaseByValue(uint _value) public { | ||
| require(count <= type(uint).max - _value, "cannot increase beyond max uint"); | ||
| count += _value; |
Collaborator
There was a problem hiding this comment.
👍 Nice Logic to check for Overflow here.
| uint public count; | ||
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity ^0.8.24; | ||
|
|
Collaborator
There was a problem hiding this comment.
👎
Not sure what you got going on here, but it isn't what I think you want to do that you're doing here.
You already declared the pragma and contract Above, Why are you repeating it again, in your contract block?
| } | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
👎
The pragma, contract comment above is followed up here.
Please fix the requested changes, as this would not compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist