Skip to content

Fix BL-15383 prevent Ctrl+P print dialog #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andrew-polk wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −0
Draft

Fix BL-15383 prevent Ctrl+P print dialog #7671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/BloomExe/WebView2Browser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,27 @@ CoreWebView2NavigationStartingEventArgs args
//};
_webview.CoreWebView2.ContextMenuRequested += ContextMenuRequested;

// BL-15383: Prevent Ctrl+P from opening the WebView2 print dialog.
// Bloom has its own printing workflows; the embedded browser print UI is confusing.
_webview.CoreWebView2Controller.AcceleratorKeyPressed += (o, e) =>
{
if (
e.KeyEventKind == CoreWebView2KeyEventKind.KeyDown
|| e.KeyEventKind == CoreWebView2KeyEventKind.SystemKeyDown
)
{
if (
e.VirtualKey == (int)Keys.P
&& (e.KeyModifiers & CoreWebView2KeyModifiers.Control) != 0
&& (e.KeyModifiers & CoreWebView2KeyModifiers.Shift) == 0
&& (e.KeyModifiers & CoreWebView2KeyModifiers.Alt) == 0
)
{
e.Handled = true;
}
}
};

// This is only really needed for the print tab. But it is harmless elsewhere.
// It removes some unwanted controls from the toolbar that WebView2 inserts when
// previewing a PDF file.
Expand Down