Show canvas tool when making cover page custom layout (BL-15977)#7767
Show canvas tool when making cover page custom layout (BL-15977)#7767JohnThomson merged 1 commit intomasterfrom
Conversation
6b1661a to
ce6c05f
Compare
ce6c05f to
de39919
Compare
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson reviewed 1 file and made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on StephenMcConnel).
src/BloomExe/web/controllers/EditingViewApi.cs line 182 at r3 (raw file):
if (switchingToCustom) { pageElt.SetAttribute("data-tool-id", "canvas");
It's not clear to me that we need to do all this here as well as in JS. The state of the toolbox and the data-tool-id that we set in TS should be saved automatically. I think it's at least worth a try to see if we can do without this, and comment on the apparently duplication if it is necessary.
de39919 to
183857f
Compare
StephenMcConnel
left a comment
There was a problem hiding this comment.
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on JohnThomson).
src/BloomExe/web/controllers/EditingViewApi.cs line 182 at r3 (raw file):
Previously, JohnThomson (John Thomson) wrote…
It's not clear to me that we need to do all this here as well as in JS. The state of the toolbox and the data-tool-id that we set in TS should be saved automatically. I think it's at least worth a try to see if we can do without this, and comment on the apparently duplication if it is necessary.
Setting the data-tool-id needs to stay in C#, but the BookInfo settings aren't needed once I figured out the sequence of events in JS and fixed things there.
183857f to
0ca4b54
Compare
0ca4b54 to
95fe3c2
Compare
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on StephenMcConnel).
This change is