Skip to content

Restore including videos in epubs (BL-16051) #7770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephenMcConnel merged 1 commit into from
Mar 25, 2026
+6 −4
Merged

Restore including videos in epubs (BL-16051) #7770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BloomExe/Publish/Epub/EpubMaker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ public void StageEpub(WebSocketProgress progress, bool publishWithoutAudio = fal
tempBookPath,
_book.IsTemplateBook,
_omittedPageLabels,
includeVideoAndActivities: false, // no activities in Epubs.
includeFilesNeededForBloomPlayer: false, // no activities in Epubs.
includeVideos: true,
// We could enhance this if we can figure out exactly what languages we will publish audio of.
// For now, I'm including them all in this initial copy. Later stages will filter to just
// what's visible.
Expand Down
7 changes: 4 additions & 3 deletions src/BloomExe/Publish/PublishHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,8 @@ public static Book.Book MakeDeviceXmatterTempBook(
string tempFolderPath,
bool isTemplateBook,
Dictionary<string, int> omittedPageLabels = null,
bool includeVideoAndActivities = true,
bool includeFilesNeededForBloomPlayer = true,
bool includeVideos = true,
string[] narrationLanguages = null,
bool wantMusic = false,
bool wantFontFaceDeclarations = true,
Expand All @@ -1003,8 +1004,8 @@ public static Book.Book MakeDeviceXmatterTempBook(
{
var filter = new BookFileFilter(bookFolderPath)
{
IncludeFilesNeededForBloomPlayer = includeVideoAndActivities,
WantVideo = includeVideoAndActivities,
IncludeFilesNeededForBloomPlayer = includeFilesNeededForBloomPlayer,
WantVideo = includeVideos,
NarrationLanguages = narrationLanguages,
WantMusic = true,
};
Expand Down